Repository navigation
fix(ui): drop the decision models sublabel from the Add Model provider dropdown - #45755
Merged
Merged
Conversation
…r dropdown Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
|
kerry seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
kerrylu-berri
approved these changes
Oct 10, 2026
kerrylu-berri
enabled auto-merge (squash)
October 10, 2026 07:04
Contributor
|
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Merged
19 of 21 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR
Problem this solves:
How it solves it:
Intentional product change: the provider dropdown on Add Model no longer lists each provider's decision models under its name. The decision model note under the model picker, the Decisions banner, and decision model detection are unchanged
User Flow
Before: an admin opening the provider dropdown sees a second line under decision providers
typeAfter: the same option shows the provider name and logo only
typePre-Submission checklist
Please complete all items before asking a LiteLLM maintainer to review your PR
uv run pytest tests/unit/<your_test_file>.py -v. Leave the suites (make test-unit-*,make test-unit) to CI: it finishes in ~15 minutes where a laptop takes an hour or more@greptileaito re-request a review after pushing changes)Screenshots / Proof of Fix
Setup: a local proxy on :4000 with one dummy openai deployment, the Admin UI dev server (
npm run devinui/litellm-dashboard) on :3000, logged in as the proxy admin. Same URL, same data, sametypefilter on both sidesBefore (2d896d5)
typeAfter (22adc1e)
typenpx vitest run src/lib/decisionModels.test.ts src/components/add_modelpasses (46 files, 1098 tests). The two tests that asserted the sublabel text and the per-provider name list are removed with the featureType
🧹 Refactoring
Final Attestation
Link to Devin session: https://app.devin.ai/sessions/c6b232da7c8e49069a5615741db63b9b
Open in Devin Desktop: https://app.devin.ai/desktop/session/c6b232da7c8e49069a5615741db63b9b?variant=devin
Requested by: @kerry-berri
Note
Devin errored when opening this Pull Request as kerry-berri.
As a fallback, Devin opened this PR as itself.