Skip to content

fix(ui): drop the decision models sublabel from the Add Model provider dropdown - #45755

Merged
kerrylu-berri merged 2 commits into
mainfrom
litellm_remove_decision_provider_sublabel
Oct 10, 2026
Merged

kerrylu-berri merged 2 commits into
mainfrom
litellm_remove_decision_provider_sublabel

Conversation

@devin-ai-integration

@devin-ai-integration devin-ai-integration Bot commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor

TLDR

Problem this solves:

  • Every provider option in the Add Model dropdown carried a "Decision models: ..." line
  • It made the provider list taller and noisier for a detail few admins need there

How it solves it:

  • Drop the sublabel from the provider options in the Add Model form
  • Remove the helper that built it and the per-provider name list it needed

Intentional product change: the provider dropdown on Add Model no longer lists each provider's decision models under its name. The decision model note under the model picker, the Decisions banner, and decision model detection are unchanged

User Flow

Before: an admin opening the provider dropdown sees a second line under decision providers

  1. They open http://localhost:3000/ui/models-and-endpoints/ and click the Add Model tab
  2. They click the Provider field and type type
  3. The TypeSafe option shows "Decision models: jev-1.13.0, jev-latest, jev-preview" under its name

After: the same option shows the provider name and logo only

  1. They open http://localhost:3000/ui/models-and-endpoints/ and click the Add Model tab
  2. They click the Provider field and type type
  3. The TypeSafe option shows only the logo and the name TypeSafe

Pre-Submission checklist

Please complete all items before asking a LiteLLM maintainer to review your PR

  • I have added meaningful tests (this PR removes a feature and its three tests, no new behavior to cover)
  • The handful of test files covering my change pass locally, e.g. uv run pytest tests/unit/<your_test_file>.py -v. Leave the suites (make test-unit-*, make test-unit) to CI: it finishes in ~15 minutes where a laptop takes an hour or more
  • My PR passes all required CI/CD checks (e.g., lint, schema.d.ts sync check, etc.)
  • My PR's scope is as isolated as possible; it only solves 1 specific problem
  • I have received a Greptile Confidence Score of at least 4/5 before requesting a maintainer review (Greptile reviews automatically once the PR is opened; only comment @greptileai to re-request a review after pushing changes)

Screenshots / Proof of Fix

Setup: a local proxy on :4000 with one dummy openai deployment, the Admin UI dev server (npm run dev in ui/litellm-dashboard) on :3000, logged in as the proxy admin. Same URL, same data, same type filter on both sides

Before (2d896d5)

  1. Open http://localhost:3000/ui/models-and-endpoints/, click Add Model, click Provider, type type
  2. The TypeSafe option renders a "Decision models: jev-1.13.0, jev-latest, jev-preview" line under the provider name

before

After (22adc1e)

  1. Open http://localhost:3000/ui/models-and-endpoints/, click Add Model, click Provider, type type
  2. The TypeSafe option renders only the logo and the name

after

npx vitest run src/lib/decisionModels.test.ts src/components/add_model passes (46 files, 1098 tests). The two tests that asserted the sublabel text and the per-provider name list are removed with the feature

Type

🧹 Refactoring

Final Attestation

  • The tests check the right things, including the edge cases, and regressions in the respective real-world customer use-cases are not possible after this PR

Link to Devin session: https://app.devin.ai/sessions/c6b232da7c8e49069a5615741db63b9b
Open in Devin Desktop: https://app.devin.ai/desktop/session/c6b232da7c8e49069a5615741db63b9b?variant=devin
Requested by: @kerry-berri


Note

Devin errored when opening this Pull Request as kerry-berri.
As a fallback, Devin opened this PR as itself.

…r dropdown

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
@devin-ai-integration

Copy link
Copy Markdown
Contributor Author

I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".

  • Disable automatic comment, CI, and merge conflict monitoring

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


kerry seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@kerrylu-berri
kerrylu-berri enabled auto-merge (squash) October 10, 2026 07:04
@greptile-apps

greptile-apps Bot commented Oct 10, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[Medium impact] This PR appears safe to merge.

Summary

Removes the decision-model sublabel from the Add Model provider dropdown.

  • Provider choices in Add Model show only a logo and name.

devin-ai-integration[bot] explicitly described removing the dropdown sublabel as intentional, to make the provider list shorter and quieter.

Reviews (1) · Last reviewed commit: "fix(ui): drop the decision models sublab..." · Reviewed by Greptile

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants