Repository navigation
feat(ui): rename the Playground System One tab to Decisions and give the JSON editor VS Code light and dark themes - #45729
Conversation
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
…he VS Code Dark+ JSON theme Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
|
kerry seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
|
bugbot run |
…breakdown accents Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
|
bugbot run |
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
…wap stops the React style warning Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
|
bugbot run |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 27f3b46. Configure here.
TLDR
Problem this solves:
How it solves it:
3.98instead of3.9809950180008897), the Raw response keeps the full valuebackgroundandbackgroundColorkeys from the two Prism block styles before the theme swap, so flipping light and dark no longer logs React's "Removing a style property during rerender" console error fromJsonEditorIntentional product change: the colored bands behind model, state and questions and the breakdown card's colored borders are gone
User Flow
Before: an admin trying a decision model reads the request JSON through colored bands and unfamiliar colors
After: the same admin finds a Decisions tab and a JSON editor colored like VS Code in their theme
Pre-Submission checklist
Please complete all items before asking a LiteLLM maintainer to review your PR
uv run pytest tests/unit/<your_test_file>.py -v. Leave the suites (make test-unit-*,make test-unit) to CI: it finishes in ~15 minutes where a laptop takes an hour or more@greptileaito re-request a review after pushing changes)Screenshots / Proof of Fix
Both captures are the dashboard dev server on port 3000 against a live proxy on port 4000 with azure-microsoft-decision-1 loaded, at http://localhost:3000/playground/?tab=system-one with the JSON tab selected
Before (4f08cf2)
After (27f3b46)
Link to Devin session: https://app.devin.ai/sessions/f08f36d6b15149878bc762ca06e03409
Open in Devin Desktop: https://app.devin.ai/desktop/session/f08f36d6b15149878bc762ca06e03409?variant=devin
Requested by: @kerry-berri
Note
Devin errored when opening this Pull Request as kerry-berri.
As a fallback, Devin opened this PR as itself.
Note
Low Risk
Playground UI labeling and JSON editor styling only; no API or auth changes.
Overview
Renames the Playground System One tab to Decisions while keeping the
?tab=system-onedeep link. Playground tests now assert the Decisions label.The request JSON editor drops the custom root-key line bands (
model/state/questions) and thefindRootBlocksscanner (module and tests removed). Syntax highlighting now uses VS Code-style Prism themes (vscDarkPlusin dark mode, a light VS Code Light+-style palette otherwise), with a dark editor surface in dark mode and simplified line gutters—no per-block colored stripes.Question breakdown no longer applies the colored left-border accents that matched those root blocks; layout is plain sections and bordered question cards.
Reviewed by Cursor Bugbot for commit 6b8fadc. Bugbot is set up for automated code reviews on this repo. Configure here.
Tutorial video recorded against the live rig, 15 numbered steps across Form and JSON, both inputs, Light+ and Dark+, and the Question breakdown: https://app.devin.ai/api/presigned_proxy?token=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJ1c2VyX2lkIjpudWxsLCJidWNrZXRfbmFtZSI6ImRldmluYXR0YWNobWVudHMiLCJidWNrZXRfa2V5IjoiYXR0YWNobWVudHNfcHJpdmF0ZS9vcmctNThkZGJiMTRjYzY5NDRiNjg0ZjgxZTk0MTlhZmU4YmUvZGJkYjlhY2MtOTRkYi00MjhkLWFiNWQtZDJkZWRkNWYzN2QzIiwiaWF0IjoxNzkxNjEyNzAyLCJvcmdfaWQiOiJvcmctNThkZGJiMTRjYzY5NDRiNjg0ZjgxZTk0MTlhZmU4YmUiLCJmaWxlbmFtZSI6ImRlY2lzaW9uc190dXRvcmlhbC5tcDQifQ.wE9AH-kSl3P5vMkeanwu3aWYGQ4vOPIc-cIvQHKHgXk
Note
Devin errored when opening this Pull Request as kerry-berri.
As a fallback, Devin opened this PR as itself.
Note
Low Risk
Playground UI-only changes (tab label, editor styling, score display formatting) with no API or auth impact; deep links still use
system-one.Overview
Renames the Playground System One tab to Decisions while keeping the
?tab=system-onedeep link. Updates the related tab test expectations.The request JSON editor now follows the dashboard theme with VS Code Light+ / Dark+ Prism themes (
next-themes), a dark editor pane in dark mode, and transparent syntax backgrounds instead of custom Tailwind token colors. It removes the colored line bands formodel/state/questionsby deleting therootBlocksscanner and simplifying the line renderer; Question breakdown drops the matching colored left borders.Response score badges use
Intl.NumberFormat(max 2 fraction digits) so values like3.98display cleanly; raw JSON is unchanged. Adds a unit test for score formatting.Reviewed by Cursor Bugbot for commit 27f3b46. Bugbot is set up for automated code reviews on this repo. Configure here.