Repository navigation
fix(github_copilot): disable shared device login on the proxy #45697
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -1337,6 +1337,9 @@ async def proxy_startup_event(app: FastAPI) -> AsyncGenerator[ProxyLifespanState | |
| shared_aiohttp_session | ||
| import json | ||
|
|
||
| from litellm.llms.github_copilot.authenticator import disable_github_copilot_shared_login | ||
|
|
||
| disable_github_copilot_shared_login() | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Existing shared-token deployments now return 401, but the title lacks the breaking-change marker required by the repository. Change it to Rule Used: What: When a PR changes behavior that existing users rely on, the PR title must mark it breaking with Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
The supplied proof shows rejected requests but no connected-user success, Responses or embeddings calls, or dashboard setup. The repository requires live proof across affected endpoints and both success and failure paths. Add those cases before merging Rule Used: Flag if the PR has no proof of e2e testing (if e2e testing is applicable here. If it's like an AGENTS.md change or something then probably no need to have e2e test proof) that either doesn't exist, claims that the box that it was trying to run in doe... (source) Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time! |
||
| init_verbose_loggers() | ||
|
|
||
| prometheus_multiproc_dir: Final = os.environ.get("PROMETHEUS_MULTIPROC_DIR") | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
_get_github_copilot_shared_api_keyadds GitHub Copilot鈥檚 error mapping tomain.py. The repository requires provider-specific logic insidelitellm/llms/<provider>/. Move the helper there before mergingRule Used: What: Keep provider-specific logic inside litellm/llms/<provider>/. Shared code (main.py, utils.py, router.py, proxy/) should not branch on a provider name. Why: provider branches in shared code spread across the codebase and break silently when a p... (source)