Skip to content

fix(ci): restore Rust retention and feature-matrix checks - #45364

Open
martin-collado-dvt wants to merge 3 commits into
BerriAI:mainfrom
martin-collado-dvt:litellm_schema_retention_test
Open

martin-collado-dvt wants to merge 3 commits into
BerriAI:mainfrom
martin-collado-dvt:litellm_schema_retention_test

Conversation

@martin-collado-dvt

@martin-collado-dvt martin-collado-dvt commented Oct 8, 2026 •

Copy link
Copy Markdown

TLDR

Problem this solves:

  • Rust-wheel fails on an outdated Lens retention expectation
  • Rust feature-matrix artifacts exhaust the runner disk

How it solves it:

  • Check the final four TTL statements, including Lens feedback
  • Omit CI-only debug metadata for dev and test builds

User Flow

Before: the Rust-wheel check fails although all four tables receive the configured retention.

  1. Run the existing Rust-wheel check on main.
  2. Its retention assertion fails because it expects three final requests.

After: the same check validates retention on all four tables.

  1. Run the same Rust-wheel check with this test-only change.
  2. The assertion verifies all four requests, including Lens feedback.

Relevant issues

Unblocks #45316. Production Lens feedback retention was added in #45171; this updates its existing Python contract test.

Implementation

Check the final four HTTP statements instead of the final three and include the existing Lens feedback statement. Keep the assertion that every TTL statement uses the configured retention, including historical migrations. The Rust test job also disables dev/test debug metadata through Cargo profile environment settings. Its feature matrix and assertions remain intact, and production build profiles stay unchanged. See Cargo profile configuration.

Pre-Submission checklist

  • Strengthens the existing regression instead of skipping or loosening it
  • Original assertion fails and corrected assertion passes locally with the compiled native bridge
  • Required current-tip CI passes
  • Scope is restoring Rust CI: retention contract and runner disk usage
  • Greptile confidence is 5/5 on the current tip

Screenshots / Proof of Fix

The native schema and failing test are byte-identical on main and #45316. Main's Rust-wheel run shows the same failure. A real pinned ClickHouse instance confirms seven-day TTLs on all four tables. The original test fails locally and the corrected test passes with the real compiled native bridge. Both schema-setup tests pass locally, including writer-credential rejection. All 104 current-tip checks pass, including the complete Rust feature matrix and native wheel tests. Greptile, Cursor Bugbot and Veria checks are favorable.

Before (d8c0e2c)

  1. Provision a local ClickHouse schema with seven-day retention using the native storage implementation.
  2. The database contains otel_traces, agent_traces_by_key, spend_logs and lens_feedback, each with seven-day retention; the old test omits the fourth statement.

After (8e4e349)

  1. Provision the same local schema with the unchanged native storage implementation.
  2. The corrected assertion checks the final four-statement sequence and every earlier TTL statement still uses seven days. A current-tip native bridge run provisions the real schema successfully.

The separate feature-matrix failure is runner disk exhaustion: rustc-LLVM ERROR: IO failure on output stream: No space left on device. Greptile gives the current tip 5/5. Cursor Bugbot and Veria checks passed without findings. The current-tip Rust run passes the entire matrix, native wheel tests and lint.

Native bridge and real ClickHouse commands with observed output

Type

Test and CI fix

Caveats

Low

  • CI builds omit source-level debugger metadata

Final Attestation

  • Required checks and review gates are satisfied

@martin-collado-dvt

Copy link
Copy Markdown
Author

@greptileai review this draft at 89e732d. The original assertion fails locally; the corrected test checks four final statements without changing retention behavior.

@martin-collado-dvt

Copy link
Copy Markdown
Author

@cursor review this test-only correction at 89e732d. It preserves migration retention checks and adds the existing Lens feedback reconciliation statement.

@codecov

codecov Bot commented Oct 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@cursor cursor Bot left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stale Bugbot comment from a previous run.

@greptile-apps

greptile-apps Bot commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[High risk] Modifies CI build configuration and database retention test.

The PR appears safe to merge, with no blocking findings

What we checked:

  • CI settings reach wheel builds: The settings belong only to rust-test. rust-wheel runs separately, and the release profile remains unchanged

Summary

This PR restores Rust CI by updating the retention test and reducing debug metadata in CI builds

  • The retention test checks the final four table statements, including lens_feedback, while keeping the check that every TTL statement uses seven days
  • rust-test disables dev/test debug metadata without removing feature combinations or assertions
  • No new actionable issues were found. Only the workflow settings changed since the previous review

Reviews (3) · Last reviewed commit: "ci(rust): keep feature matrix artifacts ..." · Reviewed by Greptile

@martin-collado-dvt martin-collado-dvt changed the title test(traces): include Lens feedback in retention assertion fix(ci): restore Rust retention and feature-matrix checks Oct 8, 2026
@martin-collado-dvt

Copy link
Copy Markdown
Author

@greptileai review this draft at 8e4e349. Both schema tests pass; Cargo CI profiles now address the separately observed runner disk exhaustion.

@martin-collado-dvt

Copy link
Copy Markdown
Author

@cursor review the current tip 8e4e349, preserving every feature-matrix case while reducing debug metadata and correcting the final Lens retention expectation.

@martin-collado-dvt

Copy link
Copy Markdown
Author

@veria-ai please review this draft at 8e4e349 for the test expectation and CI-only Cargo profile changes restoring native Rust verification.

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit 8e4e349. Configure here.

@martin-collado-dvt
martin-collado-dvt marked this pull request as ready for review October 8, 2026 13:15
@martin-collado-dvt
martin-collado-dvt requested a review from a team October 8, 2026 13:15

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant