Repository navigation
fix(ci): restore Rust retention and feature-matrix checks - #45364
martin-collado-dvt wants to merge 3 commits into
Conversation
|
@greptileai review this draft at 89e732d. The original assertion fails locally; the corrected test checks four final statements without changing retention behavior. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
|
@greptileai review this draft at 8e4e349. Both schema tests pass; Cargo CI profiles now address the separately observed runner disk exhaustion. |
|
@veria-ai please review this draft at 8e4e349 for the test expectation and CI-only Cargo profile changes restoring native Rust verification. |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 8e4e349. Configure here.
TLDR
Problem this solves:
How it solves it:
User Flow
Before: the Rust-wheel check fails although all four tables receive the configured retention.
After: the same check validates retention on all four tables.
Relevant issues
Unblocks #45316. Production Lens feedback retention was added in #45171; this updates its existing Python contract test.
Implementation
Check the final four HTTP statements instead of the final three and include the existing Lens feedback statement. Keep the assertion that every TTL statement uses the configured retention, including historical migrations. The Rust test job also disables dev/test debug metadata through Cargo profile environment settings. Its feature matrix and assertions remain intact, and production build profiles stay unchanged. See Cargo profile configuration.
Pre-Submission checklist
Screenshots / Proof of Fix
The native schema and failing test are byte-identical on main and #45316. Main's Rust-wheel run shows the same failure. A real pinned ClickHouse instance confirms seven-day TTLs on all four tables. The original test fails locally and the corrected test passes with the real compiled native bridge. Both schema-setup tests pass locally, including writer-credential rejection. All 104 current-tip checks pass, including the complete Rust feature matrix and native wheel tests. Greptile, Cursor Bugbot and Veria checks are favorable.
Before (d8c0e2c)
otel_traces,agent_traces_by_key,spend_logsandlens_feedback, each with seven-day retention; the old test omits the fourth statement.After (8e4e349)
The separate feature-matrix failure is runner disk exhaustion:
rustc-LLVM ERROR: IO failure on output stream: No space left on device. Greptile gives the current tip 5/5. Cursor Bugbot and Veria checks passed without findings. The current-tip Rust run passes the entire matrix, native wheel tests and lint.Native bridge and real ClickHouse commands with observed output
Type
Test and CI fix
Caveats
Low
Final Attestation