Skip to content

fix(responses): join function_call_output text parts with a newline in the chat-completions bridge #45338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
devin-ai-integration wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(responses): join function_call_output text parts with a newline in the chat-completions bridge #45338

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4264079
fix(responses): join function_call_output text parts with a newline i…
mateo-berri Oct 8, 2026
574b96a
test(responses): pin that a text part's leading whitespace survives t…
mateo-berri Oct 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion litellm/responses/litellm_completion_transformation/transformation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1639,7 +1639,7 @@ def _normalize_function_call_output_to_tool_content(
# Ensure we include any accumulated text as text blocks too
return normalized_blocks
if text_acc:
return "".join(text_acc)
return "\n".join(text_acc)
try:
# last resort: keep something meaningful for providers that require a string
import json as _json
Expand Down
23 changes: 19 additions & 4 deletions ...it/responses/litellm_completion_transformation/test_function_call_output_normalization.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,14 +11,14 @@
)


def test_function_call_output_list_input_text_is_converted_to_tool_string_content():
def test_function_call_output_list_input_text_parts_reach_the_tool_message_on_separate_lines():
out = LiteLLMCompletionResponsesConfig._transform_responses_api_tool_call_output_to_chat_completion_message(
tool_call_output={
"type": "function_call_output",
"call_id": "call_1",
"output": [
{"type": "input_text", "text": "hello"},
{"type": "input_text", "text": " world"},
{"type": "input_text", "text": "Paris: 22 degrees"},
{"type": "input_text", "text": "clear skies"},
Comment thread
greptile-apps[bot] marked this conversation as resolved.
],
}
)
Expand All @@ -27,7 +27,22 @@ def test_function_call_output_list_input_text_is_converted_to_tool_string_conten
msg = out[0]
assert msg["role"] == "tool"
assert msg["tool_call_id"] == "call_1"
assert msg["content"] == "hello world"
assert msg["content"] == "Paris: 22 degrees\nclear skies"


def test_function_call_output_text_part_whitespace_survives_the_join():
out = LiteLLMCompletionResponsesConfig._transform_responses_api_tool_call_output_to_chat_completion_message(
tool_call_output={
"type": "function_call_output",
"call_id": "call_1",
"output": [
{"type": "input_text", "text": "hello"},
{"type": "input_text", "text": " world"},
],
}
)

assert out[0]["content"] == "hello\n world"


def test_function_call_output_string_passthrough():
Expand Down
Loading