Skip to content

fix(lens): block teamless feedback writes and fix retention test - #45266

Merged
yujonglee-berri merged 8 commits into
mainfrom
litellm_lens_feedback_followup
Oct 8, 2026
Merged

yujonglee-berri merged 8 commits into
mainfrom
litellm_lens_feedback_followup

Conversation

@ishaan-berri

Copy link
Copy Markdown
Contributor

Relevant issues

Follow-up to #45171, which merged before these fixes landed.

Pre-Submission checklist

  • I have added meaningful tests
  • The handful of test files covering my change pass locally
  • My PR passes all required CI/CD checks
  • My PR's scope is as isolated as possible; it only solves 1 specific problem

Type

🐛 Bug Fix

Changes

The misc / proxy-infra-root failures on #45171 came from Moyai (#45196). Main already fixed them in #45220. The rust-test failure was the CI runner's linker crashing (ld terminated with signal 7 [Bus error]), not a test.

🤖 Generated with Claude Code

@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@greptile-apps

greptile-apps Bot commented Oct 8, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[Medium risk] Feedback write access control and test fixes.

The PR appears safe to merge, with no actionable issues found

What we checked:

  • Teamless feedback stays protected: Both write routes call write_scope before changing feedback. It now rejects this caller before the query can treat an empty key as a wildcard
  • Retention test matches setup: Schema setup applies migrations first, then sends four retention statements in the same order the test expects

Summary

Blocks non-admin feedback writes when the caller has neither a team nor an API key

  • Adds a regression test covering overwrite and delete attempts on a teamless trace
  • Updates the retention test to include lens_feedback
  • Simplifies summary comprehensions and removes routine UI comments
  • No actionable issues found. Tests were inspected, not run

Reviews (1) · Last reviewed commit: "chore(lens-ui): drop routine comment on ..." · Reviewed by Greptile

@codspeed

codspeed Bot commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

Merging this PR will not alter performance

✅ 31 untouched benchmarks


Comparing litellm_lens_feedback_followup (854f0c4) with main (03ba79d)

Open in CodSpeed

@codecov

codecov Bot commented Oct 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@yujonglee-berri
yujonglee-berri merged commit f824d11 into main Oct 8, 2026
120 of 122 checks passed
@yujonglee-berri
yujonglee-berri deleted the litellm_lens_feedback_followup branch October 8, 2026 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants