Repository navigation
fix(lens): block teamless feedback writes and fix retention test - #45266
Merged
Merged
Conversation
|
|
Contributor
|
Contributor
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
yujonglee-berri
approved these changes
Oct 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Relevant issues
Follow-up to #45171, which merged before these fixes landed.
Pre-Submission checklist
Type
🐛 Bug Fix
Changes
Scope(team_id="", api_key_hash=""), which the feedback target query treats as a wildcard. They could overwrite or delete another key's feedback on a teamless trace.write_scopenow returns 403 for that case. New testtest_a_caller_without_a_team_or_key_cannot_write_on_a_teamless_tracefails without the fix.test_schema_setup_uses_configured_retentionnow expects thelens_feedbackTTL statement that feat(lens): show end-user feedback on traces, stored in ClickHouse #45171 added.forcomprehension infeedback_repository.py(LIT014) and in the test fake, and dropped four routine doc comments in the Lens UI.The
misc/proxy-infra-rootfailures on #45171 came from Moyai (#45196). Main already fixed them in #45220. Therust-testfailure was the CI runner's linker crashing (ld terminated with signal 7 [Bus error]), not a test.🤖 Generated with Claude Code