Skip to content

feat(traces): tracing development seed - #44363

Merged
yujonglee-berri merged 46 commits into
mainfrom
litellm_tracing_dev_seed
Oct 3, 2026
Merged

yujonglee-berri merged 46 commits into
mainfrom
litellm_tracing_dev_seed

Conversation

@devin-ai-integration

@devin-ai-integration devin-ai-integration Bot commented Oct 3, 2026 •

Copy link
Copy Markdown
Contributor

TLDR

Problem this solves:

  • Long-running tracing development branch needs review and CI coverage
  • Traces, ClickHouse export, and dev fixtures were not on main

How it solves it:

  • Lands the litellm_tracing_dev_seed branch as one reviewable PR
  • Rust traces and traces-clickhouse crates with generated wire contracts
  • Span normalization rules isolated per format with behavior tests
  • Dev fixture seeder produces linked tracing and spend rows locally
  • ClickHouse spend rows redact credential-like custom metadata
  • Custom metadata is dropped entirely when message logging is off
  • Success rows with no calculated cost keep spend as null
  • Clearing a tag's max budget in the UI now removes it

Caveats (if any)

Severe

  • Development seed branch: contains wip and checkpoint commits, roughly 40k added lines
  • No live-proxy QA run captured yet; the proof section stays empty until one is run

Medium

  • Custom metadata like prompt is still stored when message logging is on
    • Only credential-named keys are redacted in that mode

Type

🆕 New Feature
🐛 Bug Fix

Link to Devin session: https://app.devin.ai/sessions/f4624b86e1e241aba359c4274f653d25
Open in Devin Desktop: https://app.devin.ai/desktop/session/f4624b86e1e241aba359c4274f653d25?variant=devin
Requested by: @yujonglee-berri

Each span format (Claude Code, LangSmith, OpenInference, gen_ai) now lives under
normalize/convention/ as a unit struct implementing Convention, owning both its
detection and its extraction. Precedence is one ordered registry instead of an
if-chain in mod.rs that reached into each module differently.

The modules now share one way to read attributes: present() for the first
non-empty key and Payload for a text that also reports the key it consumed,
replacing three different idioms and the &mut Vec threaded through payload
readers. Instrumentation::adjust returns a new Extraction instead of mutating
one, with each SDK rule as its own function, and the LangChain middleware
suffix list exists once.
@devin-ai-integration

Copy link
Copy Markdown
Contributor Author

I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".

  • Disable automatic comment, CI, and merge conflict monitoring

@greptile-apps

greptile-apps Bot commented Oct 3, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 1/5

[High risk] Database schema migrations and trace storage configuration.

The PR is not ready to merge because interrupted or restarted background settlements can lose billing, and pending settlement rows can retain sensitive reservation metadata.

Summary

This PR adds tracing storage and normalization, generated trace contracts, and development fixtures. Changes since the previous review also add durable background-interaction settlement, GitLab ROI support, and dashboard and proxy updates.

  • Background settlement needs recovery for interrupted claims and the creating deployment’s retrieval configuration.
  • Its persisted context also needs protection for sensitive reservation metadata.

Reviews (2) · Last reviewed commit: "Merge remote-tracking branch 'origin/mai..."

Comment thread litellm/integrations/clickhouse/clickhouse_spend_logger.py Outdated
Comment thread ui/litellm-dashboard/src/app/(dashboard)/tag-management/_components/tag_info.tsx Outdated
Comment thread litellm/integrations/clickhouse/clickhouse_spend_logger.py Outdated
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
@codspeed

codspeed Bot commented Oct 3, 2026 •

Copy link
Copy Markdown
Contributor

Merging this PR will not alter performance

✅ 31 untouched benchmarks


Comparing litellm_tracing_dev_seed (d999a07) with main (d260765)

Open in CodSpeed

@codecov

codecov Bot commented Oct 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@yujonglee-berri
yujonglee-berri enabled auto-merge (squash) October 3, 2026 09:10
yujonglee-berri and others added 6 commits October 3, 2026 09:22
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
@devin-ai-integration

Copy link
Copy Markdown
Contributor Author

@greptileai

yujonglee-berri and others added 3 commits October 3, 2026 09:51
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
@yujonglee-berri
yujonglee-berri merged commit e340e54 into main Oct 3, 2026
96 of 97 checks passed
@yujonglee-berri
yujonglee-berri deleted the litellm_tracing_dev_seed branch October 3, 2026 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant