Repository navigation
refactor(ui): compose dashboard pages with shared layouts - #44306
Merged
Merged
Conversation
Contributor
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
PageHeader drops its icon/title/subtitle/primaryAction/tabs/utilities props and the leadingControls render prop in favor of PageHeaderTitle, PageHeaderDescription and PageHeaderControls that each wrap one element and forward native props. LogsTableToolbar's 15 props collapse into one LogsTimeRange value plus composable LogsToolbar, LogsTimeRangePicker and LogsToolbarSwitch parts assembled in the panel. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Replaces the hand-rolled class-pair constants with boolean cva variants, which also brings DataTable back under the complexity budget. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
devin-ai-integration
Bot
force-pushed
the
litellm_logs_page_composition
branch
from
October 3, 2026 01:29
2e502bd to
cefc1f1
Compare
yujonglee-berri
approved these changes
Oct 3, 2026
Contributor
Contributor
|
| Math.abs( | ||
| message.x + message.width / 2 - scroller.x - scroller.width / 2, | ||
| ), | ||
| Math.abs(message.y + message.height / 2 - body.y - body.height / 2), |
Contributor
There was a problem hiding this comment.
5 of 7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR
Problem this solves:
How it solves it:
Intentional product change: standardize page spacing, remove duplicate Logs headings, and move refresh status into the toolbar. Full-height tables keep pagination at the bottom instead of immediately below the last row
User Flow
Before: Logs panels use inconsistent spacing and leave unused space below short tables
After: Logs panels share spacing and fill the available screen height
Validation
Focused Logs and table tests: 219 passed across 11 files. Shared tab tests: 98 passed across 3 files; these runs overlap
Changed-file Prettier and ESLint pass with no errors, the ESLint budget gate passes (complexity back at 140 after moving DataTable layout classes to cva variants), and knip passes. Shared, Logs and view_logs tests: 1029 passed across 90 files. Full TypeScript check: no diagnostics in changed files
Manually checked Request Logs and Deleted Teams against the local proxy on port 4000 using the dashboard dev server on port 3001
Pre-Submission checklist
Type
Refactoring
Caveats
Low
QA runbook
Prerequisites: an authenticated proxy admin session, a live proxy on port 4000, and the dashboard dev server on port 3001
tests/e2e/ui/tests/logs/logs.spec.ts/log tables fill the available height and empty requests stay centered after resizingLink to Devin session: https://app.devin.ai/sessions/d4d393c22eda4c3cabea94ab85532ed3
Open in Devin Desktop: https://app.devin.ai/desktop/session/d4d393c22eda4c3cabea94ab85532ed3?variant=devin
Requested by: @yujonglee-berri