Repository navigation
feat(ui): move LiteAdmin into the header with a docked side panel - #44293
Conversation
|
@greptileai can you reply here with a score and why that score? |
|
bugbot run |
|
Score: 4/5 This is a focused, well-tested UI change. LiteAdmin is moved cleanly into the header, the Playground-specific exclusion is removed, the popover now opens below the trigger, and the keyboard behavior correctly supports Cmd/Ctrl+J while rejecting Shift/Alt combinations. The tests cover header placement, shortcut toggling, cleanup behavior, and the hidden-account-menu state, including mutation checks. I’m holding back the final point because the required E2E/Buildkite status is still pending, so the cross-viewport layout and interaction claims have not yet been independently verified by CI. |
|
c7c6835 to
f6de39b
Compare
|
@greptileai can you reply here with a score and why that score? |
|
bugbot run |
|
Score: 5/5 This is a focused, low-risk UI change with no auth, API, or data-path impact. LiteAdmin is relocated into the dashboard header, eliminating the pager overlap and restoring access on Playground. The Cmd/Ctrl+J behavior correctly ignores Shift/Alt combinations and respects the Hide LiteAdmin setting, with cleanup when the component is unmounted. The tests cover header placement, keyboard toggling, modifier handling, hidden-state behavior, and mutation checks, so I found no actionable issues. |
f6de39b to
03bc8a0
Compare
|
@greptileai can you reply here with a score and why that score? |
|
bugbot run |
|
Score: 5/5 This is a focused, low-risk UI change with no auth, API, or data-path impact. LiteAdmin is moved into the dashboard header, eliminating the Logs pager overlap and restoring access on Playground. Cmd/Ctrl+J correctly toggles the panel while ignoring Shift/Alt combinations, and the shortcut respects the Hide LiteAdmin setting with proper listener cleanup. The added tests cover header placement, shortcut behavior, modifier handling, hidden-state behavior, and drawer navigation, so I found no actionable issues. |
03bc8a0 to
eb11f20
Compare
|
@greptileai can you reply here with a score and why that score? |
|
bugbot run |
|
Score: 5/5 This is a focused, low-risk dashboard UI change with no impact to LiteAdmin authorization, gateway write flows, or request-data paths. Moving LiteAdmin into the header and using a docked panel removes the Logs pager overlap and restores access on Playground without covering page controls. Cmd/Ctrl+J toggles the panel while Shift/Alt combinations are ignored, the Hide LiteAdmin setting still prevents the shortcut when enabled, and listener cleanup is covered. The tests cover header placement, shortcut behavior, modifier handling, hidden-state behavior, and drawer navigation, so I found no actionable issues. |
eb11f20 to
0d28d2c
Compare
|
@greptileai can you reply here with a score and why that score? |
|
bugbot run |
|
Score: 5/5 This is a focused, low-risk dashboard UI change with no impact to LiteAdmin authorization, gateway write flows, or request-data paths. Moving LiteAdmin into the header and using a docked panel removes the Logs pager overlap and restores access on Playground without covering page controls. Cmd/Ctrl+J toggles the panel while Shift/Alt combinations are ignored, the Hide LiteAdmin setting still prevents the shortcut when enabled, and listener cleanup is covered. The tests cover header placement, shortcut behavior, modifier handling, hidden-state behavior, and drawer navigation, so I found no actionable issues. |
0d28d2c to
258f6e6
Compare
|
@greptileai can you reply here with a score and why that score? |
|
bugbot run |
|
Score: 5/5 This is a focused, well-tested UI change with no impact to authentication, API behavior, or request-data paths. Moving LiteAdmin into the header and using a docked panel removes the Logs pager overlap while restoring access on Playground. Cmd/Ctrl+J toggles the panel, Shift/Alt combinations are correctly ignored, the Hide LiteAdmin setting still disables the shortcut, and listener cleanup is covered. The tests also cover header placement and drawer navigation, so I found no actionable issues. |
258f6e6 to
5d807bc
Compare
|
@greptileai can you reply here with a score and why that score? |
|
bugbot run |
|
Score: 5/5 This is a focused, well-tested UI change. Moving LiteAdmin into the header and using a docked panel removes the Logs pager overlap while restoring access on Playground without covering page controls. Cmd/Ctrl+J toggles the panel, Shift/Alt combinations are correctly ignored, the Hide LiteAdmin setting still disables the shortcut, and listener cleanup is covered. The tests also cover header placement and drawer navigation, and I found no actionable issues. |
The floating bottom-right LiteAdmin button covered page controls such as the Logs pagination buttons, and Playground had to hide it entirely. Render the trigger as a pill in the header tools ahead of Docs and open LiteAdmin as a panel docked beside the content column, which narrows the page instead of covering it. Add a Cmd/Ctrl+J toggle and drop the Playground override. The Logs and trace drawers treated Cmd+J as a plain J and advanced the selection, so they now share RunDrawer's rule that letter shortcuts yield to modified presses and typing. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
5d807bc to
2b11b8f
Compare
|
@greptileai can you reply here with a score and why that score? |
|
bugbot run |
|
Score: 5/5 This is a focused, low-risk UI change with no impact to authentication, API behavior, or request-data paths. Moving LiteAdmin into the header and using a docked panel removes the Logs pager overlap while restoring access on Playground without covering page controls. Cmd/Ctrl+J toggles the panel, Shift/Alt combinations are correctly ignored, the Hide LiteAdmin setting still disables the shortcut, and listener cleanup is covered. The tests also cover header placement, shortcut behavior, modifier handling, hidden-state behavior, and drawer navigation, so I found no actionable issues. |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 2b11b8f. Configure here.
TLDR
Problem this solves:
How it solves it:
Intentional product change: the bottom-right floating button is gone. LiteAdmin opens from the header pill (icon only below 1024px) as a panel docked on the right that narrows the page while it is open. The Hide LiteAdmin account-menu switch is unchanged
User Flow
Before: on a page with a bottom-right footer, LiteAdmin sits on top of the controls
/ui/logs/with more than one page of logs/ui/playground/: LiteAdmin is missingAfter: LiteAdmin lives in the header and covers nothing
/ui/logs/with more than one page of logs/ui/playground/and press Cmd+J: the same panel docks beside Playground, Send stays clickableChanges
infotoken with a Cmd J hint, icon only belowlgasidebeside the content column; open state lives in a frame around the column and the header pill reads it. Closing keeps the conversation and any pending reviewPre-Submission checklist
osv-scanis red, and it is red on every open PR)Screenshots / Proof of Fix
Isolated proxy and Postgres, dashboard dev server, 30 seeded request logs. Screenshots retaken at 2b11b8f (after) and its merge base 8b11b68 (before) on the same data. Same Playwright script on both arms; each pager button hit-tested at its center
Dark mode and the icon-only pill below 1024px:
Tests
DashboardHeader.test.tsx: LiteAdmin renders inside the header, ahead of DocsLiteAdmin.integration.test.tsx: Cmd+J and Ctrl+J toggle the panel, Shift+Cmd+J does not, and the shortcut does nothing while Hide LiteAdmin is onLiteAdmin.integration.test.tsx: the page mounts once across hide/unhide and the panel comes back closed; focus on open walks loading, message box and pending reviewuseKeyboardNavigation.test.tsxandTraceDrawer.test.tsx: Cmd+J / Ctrl+J leave the drawer selection alone, plain J still moves it🤖 Generated with Claude Code
Note
Low Risk
Dashboard-only UI and keyboard-handling changes; LiteAdmin gateway behavior is unchanged aside from layout and shortcuts, with tests covering the main regressions.
Overview
LiteAdmin moves from a fixed bottom-right popover to a header control (before Docs) and a right-docked
asidethat narrows the content column instead of overlaying it. The dashboard wraps the content column inLiteAdminFrame(open state, Cmd/Ctrl+J toggle, docked panel); the default export is now the header trigger button.The Playground route hide is removed so LiteAdmin is available there again. Popover UI is replaced with a docked panel, focus-on-open behavior, and
aria-expandedon the trigger.J/K navigation in logs and trace drawers now uses shared
ignoresLetterShortcutso modified keys (e.g. Cmd+J) do not move selection while LiteAdmin uses that shortcut. Tests cover header placement, integration (toggle, hide, focus, mount preservation), and drawer keyboard behavior.Reviewed by Cursor Bugbot for commit 2b11b8f. Bugbot is set up for automated code reviews on this repo. Configure here.