Repository navigation
test(integration): opt the config pass-through spend-log case into auth (rc/1.105.0 backport of #44265) - #44269
Merged
Merged
Conversation
The failure spend-log row from #42695 is written for pass-through routes that run as LLM API routes, which a config route only does with auth: true. The test omitted auth and passed only while config wins (#41779) registered config entries through the typed model, where auth defaults to true. #43962 restored the pre-config-wins registration, so the route lost that status and the row was never written. Set auth: true on the route so the test covers the logging it was written for without depending on that side effect (cherry picked from commit 1d9cd9b)
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR
Problem this solves:
How it solves it:
auth: trueexplicitlyUser Flow
Before: a config pass-through route without
authis treated the way it was before config wins, and the test expects otherwise/audit-ptundergeneral_settings.pass_through_endpointswith noauthkeyAfter: the same route with
auth: truegets the failure row the test was written for/audit-ptwithauth: trueRelevant issues
Follow-up to #43962 and #42695. Backport of #44265 to rc/1.105.0
Pre-Submission checklist
Screenshots / Proof of Fix
The one test, run twice on each side against a local integration stack (Postgres 16, Redis 7, the test's own 2-worker proxy):
pytest --timeout=90 -p no:randomly tests/integration/observability/test_passthrough_upstream_error_visibility.py::test_config_pass_through_route_logs_body_and_strips_queryBefore (485ad76)
Failed: Timeout (>90.0s) from pytest-timeoutwhile polling for the failure row in_spend_error_informationAfter (1d9cd9b)
LiteLLM_SpendLogsheld exactly 2 failure rows afterwards, one per After run and none from the Before runsType
✅ Test
Caveats (if any)
Low
authstill write no spend-log row, which matches behavior before config wins