Skip to content

chore(deps): drop unused pytest-postgresql dev dependency - #44056

Merged
yuneng-berri merged 1 commit into
mainfrom
litellm_/distracted-khorana-ad764f
Oct 1, 2026
Merged

yuneng-berri merged 1 commit into
mainfrom
litellm_/distracted-khorana-ad764f

Conversation

@yuneng-berri

Copy link
Copy Markdown
Contributor

TLDR

Problem this solves:

How it solves it:

  • Drop it from the dev group in pyproject.toml
  • Remove it plus its orphaned deps (mirakuru, port-for) from uv.lock
  • Drop the stale liccheck.ini entry and CONTRIBUTING.md mention

This edits pyproject.toml, so it needs more than one reviewer before merge

Pre-Submission checklist

Please complete all items before asking a LiteLLM maintainer to review your PR

  • I have added meaningful tests
  • The handful of test files covering my change pass locally, e.g. uv run pytest tests/unit/<your_test_file>.py -v. Leave the suites (make test-unit-*, make test-unit) to CI: it finishes in ~15 minutes where a laptop takes an hour or more
  • My PR passes all required CI/CD checks (e.g., lint, schema.d.ts sync check, etc.)
  • My PR's scope is as isolated as possible; it only solves 1 specific problem
  • I have received a Greptile Confidence Score of at least 4/5 before requesting a maintainer review (Greptile reviews automatically once the PR is opened; only comment @greptileai to re-request a review after pushing changes)

Delays in PR merge?

If you're seeing a delay in your PR being merged, ping the LiteLLM Team on Slack (#pr-review).

Screenshots / Proof of Fix

There is no user-facing behavior here, so the proof is that nothing references the plugin and the lock stays consistent

Before (2cfa5ec)

  1. git grep -n -i -E 'pytest[_-]postgresql|postgresql_proc|factories\.postgresql' -- . ':!uv.lock' matches only the pyproject.toml pin, its comment, the liccheck.ini entry and the CONTRIBUTING.md mention. No test, conftest, CI workflow, Makefile or pytest config uses it
  2. uv.lock carries pytest-postgresql 7.0.2, mirakuru 3.0.2 and port-for 1.0.0

After (65fa42a)

  1. The same git grep returns nothing
  2. uv lock --check with the CI-pinned uv 0.10.9:
Resolved 459 packages in 7ms
  1. A scratch full uv lock from this tree resolves the exact same name/version set as the hand-edited lock, so the minimal edit drops only those three packages and none of the unrelated marker churn a relock adds

Type

🚄 Infrastructure

Caveats (if any)

Low

  • psycopg and psycopg-binary stay in dev
    • migration_lock.py and the CircleCI replica script still import psycopg
  • Local pytest collection was not run
    • the shared venv has a stale mcp that breaks collection unrelated to this change
    • CI is the runtime check

The pytest-postgresql based proxy tests moved to tests/integration on the real
Postgres harness in #43996, so nothing loads the plugin anymore. uv.lock is
edited by hand to drop the package and its now orphaned mirakuru and port-for
deps; uv lock --check passes and a full relock resolves the same package set
@yuneng-berri
yuneng-berri requested a review from a team October 1, 2026 18:44
@greptile-apps

greptile-apps Bot commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[Low risk] Removes an unused test dependency.

The PR appears safe to merge; no change-caused issue was identified

Summary

Removes an unused PostgreSQL pytest plugin from the dev dependency group, its orphaned lockfile packages, and stale documentation and license entries

  • Retains the PostgreSQL client packages used by the test environment

Reviews (1) · Last reviewed commit: "chore(deps): drop unused pytest-postgres..."

@codecov

codecov Bot commented Oct 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@yuneng-berri
yuneng-berri enabled auto-merge (squash) October 1, 2026 18:50
@codspeed

codspeed Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

Merging this PR will not alter performance

✅ 31 untouched benchmarks


Comparing litellm_/distracted-khorana-ad764f (65fa42a) with main (259c166)1

Open in CodSpeed

Footnotes

  1. No successful run was found on main (2cfa5ec) during the generation of this report, so 259c166 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

@yuneng-berri
yuneng-berri merged commit e725832 into main Oct 1, 2026
113 of 117 checks passed
@yuneng-berri
yuneng-berri deleted the litellm_/distracted-khorana-ad764f branch October 1, 2026 18:53

This branch is waiting to be deployed

1 waiting deployment
e2e-changed — 65fa42a8 Waiting Oct 1, 2026 by yuneng-berri via oauth #2368
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants