Skip to content

docs(proxy): point mcp_server test references at tests/unit/proxy - #44055

Merged
yuneng-berri merged 2 commits into
mainfrom
litellm_fix_stale_legacy_proxy_test_paths
Oct 1, 2026
Merged

yuneng-berri merged 2 commits into
mainfrom
litellm_fix_stale_legacy_proxy_test_paths

Conversation

@yuneng-berri

@yuneng-berri yuneng-berri commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

TLDR

Problem this solves:

  • Two files still name the deleted legacy proxy test tree
  • The mcp_server AGENTS.md test example names a deleted module

How it solves it:

  • AGENTS.md now points both test paths at tests/unit/proxy/
  • Its auth example now uses token_endpoint_auth.py, which still exists
  • Drops the utils.py comment block that cited the old test path
  • Moves its import-time env reload guidance into AGENTS.md

Relevant issues

Follow-up to #44018, which deleted the legacy proxy test tree

Pre-Submission checklist

Please complete all items before asking a LiteLLM maintainer to review your PR

  • I have added meaningful tests
  • The handful of test files covering my change pass locally, e.g. uv run pytest tests/unit/<your_test_file>.py -v. Leave the suites (make test-unit-*, make test-unit) to CI: it finishes in ~15 minutes where a laptop takes an hour or more
  • My PR passes all required CI/CD checks (e.g., lint, schema.d.ts sync check, etc.)
  • My PR's scope is as isolated as possible; it only solves 1 specific problem
  • I have received a Greptile Confidence Score of at least 4/5 before requesting a maintainer review (Greptile reviews automatically once the PR is opened; only comment @greptileai to re-request a review after pushing changes)

Screenshots / Proof of Fix

This is a docs and comment change with no runtime behavior, so the proof is the repo grep

Before (2cfa5ec)

  1. git grep -n "test_litellm/proxy"
  2. Output:
litellm/proxy/_experimental/mcp_server/AGENTS.md:92:Mirror this package under `tests/test_litellm/proxy/_experimental/mcp_server/`.
litellm/proxy/_experimental/mcp_server/utils.py:50:# ``tests/test_litellm/proxy/_experimental/mcp_server/test_mcp_server_identity_env.py``.

After (ad9469d)

  1. git grep -n "test_litellm/proxy\|tests/test_litellm" -- litellm/proxy; echo "exit=$?"
  2. Output: exit=1 with no matches
  3. ls tests/unit/proxy/_experimental/mcp_server/auth/test_token_endpoint_auth.py litellm/proxy/_experimental/mcp_server/auth/token_endpoint_auth.py tests/unit/proxy/_experimental/mcp_server/guardrail_translation/test_mcp_guardrail_handler.py lists all three files, so every path the AGENTS.md section names exists

Type

📖 Documentation

Final Attestation

  • The tests check the right things, including the edge cases, and regressions in the respective real-world customer use-cases are not possible after this PR

The legacy tests/test_litellm/proxy tree was removed in #44018. Repoint the
mcp_server AGENTS.md mirror path, swap its auth example for a module that still
exists, and drop the utils.py comment block that named the old test path
@greptile-apps

greptile-apps Bot commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[Low risk] Updates documentation paths and moves a comment.

The PR appears safe to merge.

Summary

The PR updates MCP server contributor guidance to use the current unit-test tree and removes a comment pointing to the deleted test tree. The follow-up change also updates the remaining legacy path and moves the import-time environment guidance into AGENTS.md.

Reviews (2) · Last reviewed commit: "docs(proxy): fix remaining mcp_server le..."

Comment thread litellm/proxy/_experimental/mcp_server/AGENTS.md
Comment thread litellm/proxy/_experimental/mcp_server/utils.py
@codecov

codecov Bot commented Oct 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

…t-time env reads

Repoint the second tests/test_litellm reference in the mcp_server AGENTS.md
Tests section and move the import-time env guidance there from the removed
utils.py comment
@yuneng-berri

Copy link
Copy Markdown
Contributor Author

@greptileai

@yuneng-berri
yuneng-berri enabled auto-merge (squash) October 1, 2026 18:54
@yuneng-berri
yuneng-berri merged commit c030191 into main Oct 1, 2026
89 of 92 checks passed
@yuneng-berri
yuneng-berri deleted the litellm_fix_stale_legacy_proxy_test_paths branch October 1, 2026 18:56
@codspeed

codspeed Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor

Merging this PR will not alter performance

✅ 31 untouched benchmarks


Comparing litellm_fix_stale_legacy_proxy_test_paths (ad9469d) with main (259c166)1

Open in CodSpeed

Footnotes

  1. No successful run was found on main (2cfa5ec) during the generation of this report, so 259c166 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

This branch is waiting to be deployed

1 waiting deployment
e2e-changed — ad9469dc Waiting Oct 1, 2026 by yuneng-berri via oauth #2371
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants