Skip to content

test(straiker): use a neutral gateway name in a guardrail test - #43576

Open
PhimmStraiker wants to merge 1 commit into
BerriAI:mainfrom
straiker-ai:litellm_straiker_test_neutral_gateway_name
Open

PhimmStraiker wants to merge 1 commit into
BerriAI:mainfrom
straiker-ai:litellm_straiker_test_neutral_gateway_name

Conversation

@PhimmStraiker

Copy link
Copy Markdown
Contributor

Source: Straiker's contribution from straiker-ai/litellm, the Straiker org fork.

TLDR

Problem this solves:

  • One Straiker guardrail test uses a real-sounding sample gateway name

How it solves it:

  • Swaps it for a neutral placeholder (Acme Gateway); test-only, one line, no behaviour change

🤖 Generated with Claude Code

@PhimmStraiker
PhimmStraiker requested a review from a team September 28, 2026 16:16
@greptile-apps

greptile-apps Bot commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 4/5

[Low risk] Test file updates a gateway name in a guardrail test.

The test behavior appears unchanged, but the naming instruction must be satisfied before merging

Findings

  1. P2 Company-style name in test ▶

Summary

The PR changes one source value in a mocked Straiker guardrail test

  • The new value should be replaced with a generic label to meet the repository's naming instruction

Reviews (1) · Last reviewed commit: "test(straiker): use a neutral gateway na..."

@pytest.mark.asyncio
async def test_v3_request_phase_relays_the_provider_body_and_nothing_else():
g = _make_guardrail(api_key=V3_KEY, source="Yum Gateway")
g = _make_guardrail(api_key=V3_KEY, source="Acme Gateway")

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Company-style name in test The new Acme Gateway fixture value violates the repository's instruction against company names in code. Use a generic label before merging

Suggested change
g = _make_guardrail(api_key=V3_KEY, source="Acme Gateway")
g = _make_guardrail(api_key=V3_KEY, source="Example Gateway")

Context Used: CLAUDE.md (source)

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

@codecov

codecov Bot commented Sep 28, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant