Repository navigation
fix(agents): preserve delegated team authorization context - #43459
joshua-berri wants to merge 17 commits into
Conversation
|
@greptileai @veria-ai Please review current tip cab10bd. The stack now has four PRs; delegated-team authorization is isolated in #43459. Focused remote verification runs alongside CI. Please check prior findings and current diff |
|
PR overviewAll previously flagged issues have been addressed. No open security concerns remain on this pull request. Security reviewNo open security issues remain on this pull request. Fixed/addressed: 2 · PR risk: 0/10 |
0d49d9a to
ae3909d
Compare
d288eab to
47a67bc
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
@greptileai @veria-ai Please review the current tip. The optional team-selector cleanup is absent from all four merge-base diffs; those six UI files match the original main merge-base, so incomplete group discovery is pre-existing and deferred. Identity now retains authoritative target rate policy; budgets bind explicit A2A billing to the path; PR4 preserves grant-team authority and consumes JWT verification once. Focused tests/live checks run in parallel with CI |
ae3909d to
7b5efc7
Compare
47a67bc to
750b261
Compare
|
@greptileai @veria-ai Please review the current tip and confirm resolution of the focused findings. Actor/target token settlement now reuses recorded reservation scopes; delegated tests use module-boundary isolation. No unrelated features or selector cleanup were added. Fresh verification runs in parallel with CI |
750b261 to
0e358de
Compare
7b5efc7 to
904e677
Compare
|
@greptileai @veria-ai Current tip 0e358de applies the exact Ruff formatting correction only; behavioral patches are unchanged. Focused delegated tests168pass, rate settlement2pass, and actual Entra before/after confirm grant-team model, route and budget denial. Please confirm current-tip review outcomes; remaining live controls and CI are pending |
904e677 to
9a917b5
Compare
27869aa to
4d25f3c
Compare
|
@greptileai @veria-ai Please review 4d25f3c: selected team context is immutable, with explicit fallback types. Focused regressions and all canonical gates pass. |
TLDR
Problem this solves:
How it solves it:
User Flow
Before: a user can invoke an agent using another team's restrictions
After: a team grant carries that team's restrictions
Without an explicit selector, a granting team is used, including when JWT configuration supplies an unrelated default team. Direct user grants preserve existing team selection. If multiple teams grant access, an already resolved granting team is retained; otherwise the first team in stable ID order is used. Its restrictions and billing apply, and an explicit selector must name a granting team. Autonomous agents are unchanged
Relevant issues
Stack 4 of 4, depends on #43230. Addresses the delegated-team finding in #43149: #43149 (comment)
Affected release
Linear ticket
Pre-Submission checklist
Screenshots / Proof of Fix
Actual Entra delegated tokens were tested against matched live gateways. The final published authorization code matches the tested source; the latest collection-only lint repair is undergoing focused verification
Before (0d49d9a)
After (authorization source 47a67bc)
Direct user grants retain their existing behavior. Focused permission/admission tests passed 168 cases at 750b261, whose authorization source matches the live-tested version. Current CI and the remaining focused checks are still pending
Current repair at 27869aa: seven signed-JWT regression cases pass, including team claims, aliases, explicit DB fallback, and claimless compatibility. Canonical focused Ruff checks pass; type diagnostics decrease. Current-tip CI and automated reviews are pending.
Current scoped repair at 4d25f3c: delegated team selection uses separate immutable context values. 76 JWT and 168 permission/admission tests pass on the behavior-equivalent revision; subsequent commits change annotations/format only. Full canonical lint/type gates pass at this exact tip, with no new type diagnostics. Current-tip CI, coverage and bot reviews are pending; additional live checks are running in parallel.
Type
Bug Fix
Caveats (if any)
High
Final Attestation