Repository navigation
test(e2e): report batch cleanup leftovers as a plain UserWarning - #43405
Merged
Merged
Conversation
The leftover warning used a class defined in a test-directory module. The xdist controller cannot import it, so an uncaught leftover warning crashed the whole e2e run. Same change as #43391 on rc/1.103.0
yuneng-berri
requested a deployment
to
e2e-changed
September 27, 2026 03:19 — with
GitHub Actions
Waiting
tin-berri
approved these changes
Sep 27, 2026
tin-berri
enabled auto-merge (squash)
September 27, 2026 03:21
Contributor
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This branch is waiting to be deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR
Problem this solves:
How it solves it:
UserWarninginstead ofBatchCleanupLeftoverUser Flow
Before: a release qualifier running the litellm-e2e Buildkite pipeline gets a crashed run instead of test results
INTERNALERRORandModuleNotFoundError: No module named 'batch_cleanup', and the retry step then fails with "no artifacts found"After: the same leftover shows up as a warning and the run finishes with real results
UserWarningnaming the file id and keeps going to a pass/fail verdictRelevant issues
Same change as #43391, which already fixed this on rc/1.103.0. The rc/1.104.0 copy is its own PR
Pre-Submission checklist
Please complete all items before asking a LiteLLM maintainer to review your PR
uv run pytest tests/unit/<your_test_file>.py -v. Leave the suites (make test-unit-*,make test-unit) to CI: it finishes in ~15 minutes where a laptop takes an hour or more@greptileaito re-request a review after pushing changes)The existing
tests/e2e/batches/test_batch_cleanup.pycovers both leftover paths and passes 50/50 on this branchDelays in PR merge?
If you're seeing a delay in your PR being merged, ping the LiteLLM Team on Slack (#pr-review).
Screenshots / Proof of Fix
Before (9ba552d)
6d672483c9, which has the samebatch_cleanup.pyas this base: https://buildkite.com/berriai-1/litellm-e2e/builds/313After (f7e1c32)
pytest tests/e2e/batches/test_batch_cleanup.py -q50 passed, including the two leftover cases that now assert aUserWarningwhose message names the left file and batchbuiltins, which the xdist controller can always importType
✅ Test
Caveats (if any)
Low
Final Attestation