refactor(mcp): consolidate hub publication predicate

[tin-berri]

TLDR

Problem this solves:

• Two similarly named helpers obscure one publication rule
• A standalone README repeats the visibility dialog's guidance

How it solves it:

• Combine lookup and policy in is_mcp_server_public
• Remove the extra README; retain in-dialog YAML guidance

Relevant issues

• Address the helper naming and README nits from fix(mcp): align hub publication status and controls #43241
• Preserve strict/legacy publication and database-over-config precedence

Changes

• Use one publication method for management metadata and Hub filtering
• Reuse the Hub's precomputed publication IDs for batch lookup
• Extend the existing matrix to verify explicit empty snapshots

Pre-Submission checklist

• I have added meaningful tests
• The handful of test files covering my change pass locally
• My PR passes all required CI/CD checks
• My PR's scope is as isolated as possible
• I have received a Greptile Confidence Score of at least 4/5

Screenshots / Proof of Fix

Source proxy with PostgreSQL, two registered MCP servers, strict mode and public_mcp_servers: [listed-internal]. The listed server has public-IP access disabled; the unlisted server has it enabled. This cleanup preserves the same responses

Before (7aba771)

1. GET /v1/mcp/server and each server's detail: listed-internal has is_public: true; unlisted-network has is_public: false
2. GET /public/mcp_hub: only listed-internal
3. POST /v1/mcp/make_public with {"mcp_server_ids":["unlisted-network"]}: HTTP 400 because YAML owns the setting; the Hub still contains only listed-internal

After (15a7d2f)

1. GET /v1/mcp/server and each server's detail: listed-internal has is_public: true; unlisted-network has is_public: false
2. GET /public/mcp_hub: only listed-internal
3. POST /v1/mcp/make_public with {"mcp_server_ids":["unlisted-network"]}: HTTP 400 because YAML owns the setting; the Hub still contains only listed-internal

Local validation: 125 focused tests and make check pass. Replacing the explicit None check with a truthiness fallback fails 9 matrix cases; restored code passes all 80 cases

Current commit 15a7d2fcb4: all 10 required checks pass, with 101 successful check runs, 1 skipped and 1 superseded PR-title run cancelled. Buildkite e2e passes. Greptile is 5/5; Bugbot and Veria found no issues. All three CodeQL analyses are clean. Codecov reports 100% patch coverage with 25/27 current-head uploads merged; proxy-db-custom-logging and proxy-db-budgets are still processing

Type

Refactoring

Final Attestation

• Existing publication cases and the empty-snapshot regression pass locally

[greptile-apps]

Confidence Score: 5/5

[Medium risk] Consolidates MCP server publication logic into one method.

The PR appears safe to merge; no actionable regression was identified

Summary

The PR consolidates MCP Hub publication checks into is_mcp_server_public, passes a precomputed publication-ID snapshot during Hub filtering, adds empty-snapshot coverage, and removes a standalone README whose main guidance remains in the dashboard dialog

_{Reviews (1) · Last reviewed commit: "refactor(mcp): consolidate hub publicati..."}

[tin-berri]

bugbot run Please review this small publication-helper consolidation, especially strict/legacy behavior, registry precedence, and explicit empty snapshots

[cursor]

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit 15a7d2f. Configure here.}

[codspeed]

Merging this PR will not alter performance

✅ 31 untouched benchmarks

---

_{Comparing litellm_mcp_publication_nits (15a7d2f) with main (7aba771)}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!