Repository navigation
revert: "feat(proxy): server-side Team Usage export beyond the top-N key cap (#42996)" - #43376
Conversation
|
|
|
| @@ -6818,178 +6809,6 @@ async def get_team_daily_activity_aggregated( | |||
| ) | |||
There was a problem hiding this comment.
Existing export requests break
Clients that already call /team/daily/activity/export will receive 404 after this route is removed. The repository requires backwards-incompatible changes to have a user-controlled flag, but this removal provides no way to retain the endpoint.
Rule Used: What: avoid backwards-incompatible changes without user-controlled flags Why: This breaks current behaviour for users using existing functionality Example of BAD: this PR (#22164) introduced run_post_custom... (source)
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Comments Outside DiffThese findings sit on lines the diff does not cover, so they could not be posted inline. Each one leaves this list once its file changes.
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Reverts #42996
TLDR
Problem this solves:
How it solves it:
git revertof the squash commit 77eccacGET /team/daily/activity/exportroute, its types, tests and the dashboard wiringUser Flow
Before: with more keys than
USAGE_TOP_API_KEYS_LIMIT, a proxy admin can export Team Usage from the serverAfter: the proxy behaves as it did before #42996
USAGE_TOP_API_KEYS_LIMITType
🧹 Refactoring
Caveats (if any)
Low
test_common_daily_activity.pyhad one conflict; resolved by taking the pre feat(proxy): server-side Team Usage export beyond the top-N key cap #42996 file and re-adding the fix(spend): attribute CLI session spend to the per-user cli-session alias instead of the hashed session token #40541 test🤖 Generated with Claude Code