Skip to content

test(zerobus): move tests into active CI selection - #43235

Merged
tin-berri merged 2 commits into
mainfrom
litellm_zerobus_ci_paths
Sep 25, 2026
Merged

tin-berri merged 2 commits into
mainfrom
litellm_zerobus_ci_paths

Conversation

@tin-berri

@tin-berri tin-berri commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

TLDR

Problem this solves:

  • Three Zerobus tests are missing from CI jobs

How it solves it:

  • Move them into the existing integrations unit-test selection
  • Include the empty package marker required by unit tests
  • Three unchanged renames and one empty file

User Flow

Before: contributors see failing CI discovery checks on pull requests

  1. Open the pull request's Checks tab
  2. assert-ci-coverage and assert-shard-coverage report unassigned Zerobus tests

After: the existing integrations job includes all three files

  1. Open the pull request's Checks tab
  2. Both discovery checks recognize the Zerobus tests

Relevant issues

#43194 moved integration tests to tests/unit/integrations; #42013 subsequently added Zerobus tests under the old path. This isolates three renames also present in the larger #43199

Validation

The package-layout test and all 45 Zerobus tests pass locally. Test-file contents are byte-for-byte identical to the base. Scoped lint and test-quality checks pass

The initial CI run caught the missing __init__.py in the moved directory. The empty package marker fixes that failure without adding test code. Hosted CI is rerunning for the latest commit

Screenshots / Proof of Fix

Before (e065a25)

  1. Run python .github/scripts/assert_ci_coverage.py: exits 1 and lists all three Zerobus files as invoked by no job
  2. Run python .github/scripts/assert_ci_coverage.py --shards: exits 1 because tests/test_litellm/integrations has no assigned shard

After (0710cca)

  1. Run python .github/scripts/assert_ci_coverage.py: exits 0, covering all 3,066 test files and 10 Dockerfiles
  2. Run python .github/scripts/assert_ci_coverage.py --shards: exits 0, covering all 138 test children

Pre-Submission checklist

  • Existing tests pass in their new location
  • Both CI discovery checks pass locally
  • Scope is limited to three renames and an empty package marker
  • All required hosted CI checks pass
  • Greptile confidence is at least 4/5 before requesting maintainer review

Type

Test


Note

Low Risk
Test-only path and package layout changes with no production code or behavioral test edits.

Overview
Relocates Zerobus integration tests so CI discovery assigns them to the existing integrations unit-test job, fixing assert-ci-coverage and shard-coverage failures on pull requests.

Three Zerobus test modules (test_zerobus_client, test_zerobus_logger, test_zerobus_row) move under tests/unit/integrations/zerobus/ with no test logic changes. An empty __init__.py is added so the directory is a proper package for the unit-test layout.

Reviewed by Cursor Bugbot for commit 0710cca. Bugbot is set up for automated code reviews on this repo. Configure here.

@tin-berri
tin-berri requested a review from a team September 25, 2026 22:56
@greptile-apps

greptile-apps Bot commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[Low risk] Reorganizes test files into a different directory structure.

The PR appears safe to merge based on the reviewed changes.

Summary

Moves three unchanged Zerobus test files into the integrations unit-test selection and adds the empty package marker needed for collection.

  • No new actionable issues identified.

Reviews (2) · Last reviewed commit: "test(zerobus): add package marker for un..."

@codecov

codecov Bot commented Sep 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

shrey-berri added a commit that referenced this pull request Sep 25, 2026
Port of #43235 so assert-ci-coverage and assert-shard-coverage pass on this
branch; a no-op once main carries it
@tin-berri
tin-berri merged commit 474ab91 into main Sep 25, 2026
91 checks passed
@tin-berri
tin-berri deleted the litellm_zerobus_ci_paths branch September 25, 2026 23:35
@mateo-berri

Copy link
Copy Markdown
Contributor

@greptileai

@mateo-berri

Copy link
Copy Markdown
Contributor

bugbot run

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit 0710cca. Configure here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants