Repository navigation
test(zerobus): move tests into active CI selection - #43235
Merged
Merged
Conversation
Contributor
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
7 tasks done
shrey-berri
added a commit
that referenced
this pull request
Sep 25, 2026
Port of #43235 so assert-ci-coverage and assert-shard-coverage pass on this branch; a no-op once main carries it
4 of 6 tasks
7 tasks done
tin-berri
enabled auto-merge (squash)
September 25, 2026 23:34
moe-berri
approved these changes
Sep 25, 2026
Contributor
Contributor
|
bugbot run |
Contributor
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 0710cca. Configure here.
This was referenced Sep 25, 2026
5 of 7 tasks
4 of 5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR
Problem this solves:
How it solves it:
User Flow
Before: contributors see failing CI discovery checks on pull requests
assert-ci-coverageandassert-shard-coveragereport unassigned Zerobus testsAfter: the existing integrations job includes all three files
Relevant issues
#43194 moved integration tests to
tests/unit/integrations; #42013 subsequently added Zerobus tests under the old path. This isolates three renames also present in the larger #43199Validation
The package-layout test and all 45 Zerobus tests pass locally. Test-file contents are byte-for-byte identical to the base. Scoped lint and test-quality checks pass
The initial CI run caught the missing
__init__.pyin the moved directory. The empty package marker fixes that failure without adding test code. Hosted CI is rerunning for the latest commitScreenshots / Proof of Fix
Before (e065a25)
python .github/scripts/assert_ci_coverage.py: exits 1 and lists all three Zerobus files as invoked by no jobpython .github/scripts/assert_ci_coverage.py --shards: exits 1 becausetests/test_litellm/integrationshas no assigned shardAfter (0710cca)
python .github/scripts/assert_ci_coverage.py: exits 0, covering all 3,066 test files and 10 Dockerfilespython .github/scripts/assert_ci_coverage.py --shards: exits 0, covering all 138 test childrenPre-Submission checklist
Type
Test
Note
Low Risk
Test-only path and package layout changes with no production code or behavioral test edits.
Overview
Relocates Zerobus integration tests so CI discovery assigns them to the existing integrations unit-test job, fixing
assert-ci-coverageand shard-coverage failures on pull requests.Three Zerobus test modules (
test_zerobus_client,test_zerobus_logger,test_zerobus_row) move undertests/unit/integrations/zerobus/with no test logic changes. An empty__init__.pyis added so the directory is a proper package for the unit-test layout.Reviewed by Cursor Bugbot for commit 0710cca. Bugbot is set up for automated code reviews on this repo. Configure here.