Repository navigation
fix(router): stop retries and fallbacks from re-running executed MCP tools #43159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Atharva-Kanherkar
wants to merge
15
commits into
BerriAI:main
Choose a base branch
from
Atharva-Kanherkar:fix-mcp-retry-tool-reexecution
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
8898a20
fix(router): stop retries and fallbacks after MCP tools executed
Atharva-Kanherkar f89d031
fix(mcp): tag a chat follow-up failure after MCP tools executed
Atharva-Kanherkar dcaeff7
fix(mcp): tag a Responses follow-up failure after MCP tools executed
Atharva-Kanherkar 7ccee38
fix(mcp): tag a /v1/messages follow-up failure after MCP tools executed
Atharva-Kanherkar 33a4363
fix(mcp): only block router replays after a tool actually executed
Atharva-Kanherkar de4ba11
test(router): inject the attempt instead of patching router methods
Atharva-Kanherkar c483f99
refactor(mcp): follow one link per step when looking for the replay tag
Atharva-Kanherkar e9e95d5
fix(mcp): walk the exception chain without recursion
Atharva-Kanherkar 2a8f588
fix(mcp): count a tool call once it is sent to the MCP server
Atharva-Kanherkar b1e4442
fix(mcp): stop fallbacks from replaying a streamed chat tool call
Atharva-Kanherkar d4caa30
fix(mcp): count a tool call when the MCP session sends it
Atharva-Kanherkar f78e072
test(router): keep the MCP replay tests in the router retry test file
Atharva-Kanherkar 4ad4a4d
Merge upstream main into fix-mcp-retry-tool-reexecution
Atharva-Kanherkar 99b3c06
style(mcp): drop routine comments from the replay change
Atharva-Kanherkar 8b1c0a2
Merge remote-tracking branch 'upstream/main' into fix-mcp-retry-tool-…
Atharva-Kanherkar File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.