Skip to content

ci: run every build_and_test job in every CircleCI pipeline - #43152

Merged
yuneng-berri merged 4 commits into
mainfrom
litellm_circleci_rc_branch_filters
Oct 9, 2026
Merged

yuneng-berri merged 4 commits into
mainfrom
litellm_circleci_rc_branch_filters

Conversation

@devin-ai-integration

@devin-ai-integration devin-ai-integration Bot commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

TLDR

Problem this solves:

  • 26 CircleCI jobs run only on main
  • run-ci PRs and rc pipelines skip them

How it solves it:

  • Drop the main-only branch filter from those 26 jobs
  • Every pipeline now runs the full suite; the migration cron stays on main

A run-ci PR into any base, an rc branch pipeline and main's 6-hourly pipeline all run every job. Pushes to rc/* start a pipeline only once a CircleCI project trigger for them exists, which is a settings change outside this repo

Pre-Submission checklist

Please complete all items before asking a LiteLLM maintainer to review your PR

  • I have added meaningful tests
  • The handful of test files covering my change pass locally, e.g. uv run pytest tests/unit/<your_test_file>.py -v. Leave the suites (make test-unit-*, make test-unit) to CI: it finishes in ~15 minutes where a laptop takes an hour or more
  • My PR passes all required CI/CD checks (e.g., lint, schema.d.ts sync check, etc.)
  • My PR's scope is as isolated as possible; it only solves 1 specific problem
  • I have received a Greptile Confidence Score of at least 4/5 before requesting a maintainer review (Greptile reviews automatically once the PR is opened; only comment @greptileai to re-request a review after pushing changes)

Screenshots / Proof of Fix

Before (de6a071)

  1. grep -c 'only: main' .circleci/config.yml prints 27: 26 build_and_test jobs plus the migration cron

After (28f1bfe)

  1. circleci config validate .circleci/config.yml prints Config file at ".circleci/config.yml" is valid.
  2. grep -c 'only: main' .circleci/config.yml prints 1, the migration cron
  3. Diffing circleci config process output against main shows only the 26 removed filters blocks, plus 23 job entries losing their trailing colon because the filter was their only key. Job names, requires and parameters are unchanged

Type

🚄 Infrastructure

Caveats (if any)

High

Medium

  • Pushes to rc/* still start no pipeline until a CircleCI project trigger for rc/* push events is added in project settings
  • Jobs that use path_filter.sh (client, provider-harness, redis-compat, windows-release) still halt on PRs whose changes are unrelated to them
  • rc/1.106.0 needs the same commit picked onto it after this merges

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
@devin-ai-integration
devin-ai-integration Bot requested a review from a team September 25, 2026 08:16
@devin-ai-integration

Copy link
Copy Markdown
Contributor Author

I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".

  • Disable automatic comment, CI, and merge conflict monitoring

@greptile-apps

greptile-apps Bot commented Sep 25, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[High impact] The filter removal appears safe to merge under the updated scope

Summary

Removes the 26 job-level branch filters from build_and_test, making those jobs eligible on every branch where the workflow starts

  • CircleCI’s full-suite checks can run on release-candidate branches.

Reviews (4) · Last reviewed commit: "ci: run every build_and_test job in ever..." · Reviewed by Greptile

@codecov

codecov Bot commented Sep 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

…ranch_filters

# Conflicts:
#	.circleci/config.yml
The 26 build_and_test jobs filtered to main now share one anchor that also admits branches named litellm_rc_*, so a run-ci pipeline on such a branch at an rc SHA runs the full suite. Every other PR keeps the integration-only subset, and the migration schedule stays on main
@yuneng-berri yuneng-berri changed the title ci: run the main branch CircleCI job set on rc/* branches ci: let litellm_rc_* branches run the main-only CircleCI jobs Oct 9, 2026
@yuneng-berri

Copy link
Copy Markdown
Contributor

@greptileai please review: rebased onto main and replaced with one anchor letting litellm_rc_* branches run the 26 main-only jobs

Comment thread .circleci/config.yml Outdated
@yuneng-berri

Copy link
Copy Markdown
Contributor

@greptileai please re-review: replied on the rc/* thread, rc runs go through litellm_rc_* branch PRs by design

Drop the main-only branch filter from the 26 build_and_test jobs, so a run-ci PR pipeline into any base, an rc branch pipeline and main's scheduled pipeline all run the full suite. The migration cron stays on main
@yuneng-berri yuneng-berri changed the title ci: let litellm_rc_* branches run the main-only CircleCI jobs ci: run every build_and_test job in every CircleCI pipeline Oct 9, 2026
@yuneng-berri

Copy link
Copy Markdown
Contributor

@greptileai please re-review: scope changed, the 26 main-only filters are removed so run-ci PRs, rc and main run everything

@yuneng-berri
yuneng-berri merged commit dafa9cb into main Oct 9, 2026
83 checks passed
@yuneng-berri
yuneng-berri deleted the litellm_circleci_rc_branch_filters branch October 9, 2026 19:33
yuneng-berri added a commit that referenced this pull request Oct 9, 2026
…45651)

Drop the main-only branch filter from the 26 build_and_test jobs, so a run-ci PR pipeline into any base, an rc branch pipeline and the scheduled pipeline all run the full suite. The migration cron stays on main

(cherry picked from commit dafa9cb)

Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants