Repository navigation
ci: run every build_and_test job in every CircleCI pipeline - #43152
Conversation
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
…ranch_filters # Conflicts: # .circleci/config.yml
The 26 build_and_test jobs filtered to main now share one anchor that also admits branches named litellm_rc_*, so a run-ci pipeline on such a branch at an rc SHA runs the full suite. Every other PR keeps the integration-only subset, and the migration schedule stays on main
|
@greptileai please review: rebased onto main and replaced with one anchor letting litellm_rc_* branches run the 26 main-only jobs |
|
@greptileai please re-review: replied on the rc/* thread, rc runs go through litellm_rc_* branch PRs by design |
Drop the main-only branch filter from the 26 build_and_test jobs, so a run-ci PR pipeline into any base, an rc branch pipeline and main's scheduled pipeline all run the full suite. The migration cron stays on main
|
@greptileai please re-review: scope changed, the 26 main-only filters are removed so run-ci PRs, rc and main run everything |
…45651) Drop the main-only branch filter from the 26 build_and_test jobs, so a run-ci PR pipeline into any base, an rc branch pipeline and the scheduled pipeline all run the full suite. The migration cron stays on main (cherry picked from commit dafa9cb) Co-authored-by: devin-ai-integration[bot] <158243242+devin-ai-integration[bot]@users.noreply.github.com>
TLDR
Problem this solves:
mainrun-ciPRs and rc pipelines skip themHow it solves it:
mainA
run-ciPR into any base, an rc branch pipeline and main's 6-hourly pipeline all run every job. Pushes torc/*start a pipeline only once a CircleCI project trigger for them exists, which is a settings change outside this repoPre-Submission checklist
Please complete all items before asking a LiteLLM maintainer to review your PR
uv run pytest tests/unit/<your_test_file>.py -v. Leave the suites (make test-unit-*,make test-unit) to CI: it finishes in ~15 minutes where a laptop takes an hour or more@greptileaito re-request a review after pushing changes)Screenshots / Proof of Fix
Before (de6a071)
grep -c 'only: main' .circleci/config.ymlprints27: 26build_and_testjobs plus the migration cronAfter (28f1bfe)
circleci config validate .circleci/config.ymlprintsConfig file at ".circleci/config.yml" is valid.grep -c 'only: main' .circleci/config.ymlprints1, the migration croncircleci config processoutput against main shows only the 26 removedfiltersblocks, plus 23 job entries losing their trailing colon because the filter was their only key. Job names,requiresand parameters are unchangedType
🚄 Infrastructure
Caveats (if any)
High
run-ciPR now costs a full CircleCI suite, which undoes the integration-only PR subset from ci: run only integration jobs on PR CircleCI pipelines and move router and guardrails suites to GHA #45509Medium
rc/*still start no pipeline until a CircleCI project trigger forrc/*push events is added in project settingspath_filter.sh(client, provider-harness, redis-compat, windows-release) still halt on PRs whose changes are unrelated to them