Repository navigation
ci: fix the litellm-tests unit job (sysmon, codecov on failure, env -i allowlist, selection errors, reruns param) - #42900
Merged
Merged
Conversation
…list and coverage upload on failure
Contributor
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
Merged
6 of 10 tasks
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Contributor
|
devin-ai-integration
Bot
force-pushed
the
litellm_ci_mig_1_ci_fix
branch
from
September 24, 2026 08:27
bac5f58 to
8f84ef6
Compare
Contributor
Contributor
1 similar comment
Contributor
yuneng-berri
approved these changes
Sep 24, 2026
devin-ai-integration Bot
added a commit
that referenced
this pull request
Sep 24, 2026
…i allowlist, selection errors, reruns param) (#42900) * ci: fix the litellm-tests unit job with sysmon coverage, an env allowlist and coverage upload on failure * ci: fail the unit shard when circleci tests split errors * ci: exit the unit shard cleanly when circleci tests split assigns it no files --------- Co-authored-by: yuneng <yuneng@berri.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack 1/5 of the split of #42831 (reference PR, stays open until the stack lands). Above: #42901. Carved from
litellm_ci_migration_proxy_miscat c17f440 withgit checkout -p, no rewritesTLDR
Problem this solves:
litellm-tests(ci: add tests-only CircleCI pipeline with coverage and docs validation #42773) is red on main: sysmon tracer missing, Vertex memory tests time outHow it solves it:
COVERAGE_CORE: sysmonon theunitjob,install_codecov_cliwithwhen: alwaysskip_unless_relevant->setup_test_depsorderrun_integration.shrun under anenv -iallowlistfind tests/unitselection failure or empty selection fails the jobrerunsparameter, default 0, wired to--reruns/-p no:rerunfailuresOnly
.circleci/tests.ymlchanges (21 insertions, 11 deletions). Timeout stays 90s, coverage roots stay./litellmand./enterprise/litellm_enterprise,workersanddiststay parameterized, the defaultunitjob keepsfind tests/unitType
🚄 Infrastructure
Screenshots / Proof of Fix
litellm-testson this head (definitiona1e47579-d7f3-43f1-8c6c-b20f4c3b38f7, this branch as bothconfigandcheckout): https://app.circleci.com/pipelines/github/BerriAI/litellm/90270Secret visibility inside pytest with the same allowlist:
env | cut -d= -f1 | sortinside a unit test process lists onlyCI,COVERAGE_CORE,HOME,LC_CTYPE,LITELLM_LOCAL_MODEL_COST_MAP,PATH,UV,UV_RUN_RECURSION_DEPTHandVIRTUAL_ENV. None ofOPENAI_API_KEY,AZURE_AI_API_KEY,DATABASE_URL,LITELLM_LICENSE,PROXY_MASTER_KEYor the Redis variables. Therun_integration.shstep sees onlyPATH,HOME,CIRCLE_SHA1andCIRCLE_WORKFLOW_IDand builds its own synthetic keys and URLs. No guard test is committedGreptile follow-up in 8f84ef6: the
circleci tests splitoutput is captured into a variable first, so a failing split exits the shard non-zero instead of running nothing. 5553b66 then exits 0 on an empty shard string beforemapfile, so a node that was assigned no files never hands pytest a blank pathPre-Submission checklist
Final Attestation
Link to Devin session: https://app.devin.ai/sessions/d541aba7e5844703bab65085ef2d54b2
Open in Devin Desktop: https://app.devin.ai/desktop/session/d541aba7e5844703bab65085ef2d54b2?variant=devin