Repository navigation
test(integration): restore delete_mcp teardown, tighten mcp assertions and guard coverage shutdown - #42748
Open
devin-ai-integration[bot] wants to merge 2 commits into
Open
test(integration): restore delete_mcp teardown, tighten mcp assertions and guard coverage shutdown#42748devin-ai-integration[bot] wants to merge 2 commits into
devin-ai-integration[bot] wants to merge 2 commits into
Conversation
…s and drop docstrings Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
Contributor
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR
Problem this solves:
register_mcpteardown no longer proved the DB row was gonekillcould turn a passingmcpjob redHow it solves it:
register_mcpdefaults todelete_mcpagain,cleanup=forget_mcponly where the test deletes mid-testkill -TERMin the coverage shutdown gets2>/dev/null || trueUser Flow
Test-only change to
tests/integrationand.circleci/scripts, no user-facing behavior changesRelevant issues
Follow-up to #42711
Affected release
Linear ticket
Pre-Submission checklist
Please complete all items before asking a LiteLLM maintainer to review your PR
uv run pytest tests/test_litellm/<your_test_file>.py -v. Leave the suites (make test-unit-*,make test-unit) to CI: it finishes in ~15 minutes where a laptop takes an hour or more@greptileaito re-request a review after pushing changes)Delays in PR merge?
If you're seeing a delay in your PR being merged, ping the LiteLLM Team on Slack (#pr-review).
Screenshots / Proof of Fix
The change is to tests and the CI runner script, so the proof is the
mcpgroup run against a local rig (Postgres, Redis, upstream on 8190, proxy on 4000, peer on 4001) withINTEGRATION_WORKERS=4, the same shape as the CircleCIintegration-mcpjob minus the egress guard and coverageAfter (ba07390)
.venv/bin/python tests/integration/run.py mcp --results test-results/local-mcpBUG:skips listed inexecution.jsonType
✅ Test
🚄 Infrastructure
Caveats (if any)
Low
server_mcp, whose listing is scoped to the healthy alias, and load-bearing on the other four entry pointsFinal Attestation
Link to Devin session: https://app.devin.ai/sessions/dbced03dbe4143269b1c81a7f4d27917
Open in Devin Desktop: https://app.devin.ai/desktop/session/dbced03dbe4143269b1c81a7f4d27917?variant=devin