feat(logger): dispatch Python logging through the Rust diagnostics processor by devin-ai-integration[bot] · Pull Request #42616 · BerriAI/litellm

devin-ai-integration · 2026-09-22T23:12:35Z

TLDR

Problem this solves:

Log redaction and truncation run entirely in Python on every record
Rust callers have no shared diagnostic processor to reuse

How it solves it:

Adds a litellm-logger crate owning credential redaction and diagnostic processing
Exposes NativeDiagnosticProcessor through the pyo3 bridge
litellm/_logging.py dispatches through it under LITELLM_RUST, Python fallback otherwise

User Flow

Before: an operator cannot route verbose log redaction through the native diagnostics processor

They set LITELLM_RUST=true, start the proxy, and emit a log line containing a credential
The line is redacted by the Python filters; no native processor exists to pick up

After: the same operator sees the record processed by the Rust diagnostics processor

They set LITELLM_RUST=true, start the proxy, and emit a log line containing a credential
The line comes back REDACTED from NativeDiagnosticProcessor, falling back to Python on any failure

Relevant issues

Affected release

Linear ticket

Pre-Submission checklist

Please complete all items before asking a LiteLLM maintainer to review your PR

I have added meaningful tests
The focused suites pass locally: cargo test -p litellm-logger and pytest tests/test_litellm/rust_bridge/ tests/test_litellm/test_logging.py tests/test_litellm/test_secret_redaction.py
My PR passes all required CI/CD checks
My PR's scope is as isolated as possible
I have received a current-tip Greptile confidence score of at least 4/5

Screenshots / Proof of Fix

Before (`dd32715`)

Run uv run python -c "from litellm.rust_bridge.diagnostics import PROCESSOR"
Python prints ModuleNotFoundError: No module named 'litellm.rust_bridge.diagnostics'

After (`319f686`)

Run a script that builds the processor and filters a record carrying api_key=sk-live-abcdefghijklmnop12345
With no LITELLM_RUST the catalog decides Decision.PYTHON; with LITELLM_RUST=true it decides Decision.RUST_WITH_FALLBACK
The filtered record's message comes back REDACTED, and native.redact_text("key=sk-...") returns key=REDACTED

Type

New Feature

Caveats (if any)

Low

Native path is opt-in only: LITELLM_RUST unset keeps Decision.PYTHON
Every native call wraps in RUST_WITH_FALLBACK, so a bridge failure silently reverts to Python
Sets inside log extras serialize to sorted lists after processing

Validation

cargo test -p litellm-logger passed, including parity cases generated against the Python redactor. pytest tests/test_litellm/rust_bridge/ tests/test_litellm/test_logging.py tests/test_litellm/test_secret_redaction.py passed 1941 tests with one teardown error in test_level_routing_handler_falls_back_to_stderr_when_stdout_is_unusable that reproduces identically on the merge base. cargo check -p litellm-logger is clean. Cargo.lock was regenerated after a rebase conflict against litellm-model-catalog

Final Attestation

The tests cover the redaction parity between native and Python paths and the access-log scrubbing contract

Note

Medium Risk
Touches credential redaction and all main log filters; behavior is gated and falls back to Python, but parity bugs could leak secrets or change log shape (e.g. sets in extras sorted to lists).

Overview
Introduces a shared litellm-tracing Rust crate and wires it into Python so log redaction, truncation, and native tracing events can use one diagnostics pipeline when LITELLM_RUST is enabled (catalog LoggerContext, Python fallback on failure).

Rust: Secret redaction moves out of core-utils into litellm-tracing (SecretRedactor, Processor for batch message/exception/stack/extra scrubbing, base64 collapse, access-arg scrubbing). A Logger + Sink layer forwards litellm_* events without a global subscriber. The python-bridge adds NativeDiagnosticProcessor, a PythonSink to litellm.rust_bridge.logger, and logger::run_* / LoggedMachine so cache, routes, HTTP warnings, and secrets crates emit through that sink instead of ad hoc Python warn calls.

Python: DiagnosticProcessingFilter replaces the old split between stdout truncation and inline secret scrubbing via _process_record, delegating to the native processor through rust_bridge.diagnostics.run. secret_redaction and access-log filters use the same path. rust_bridge/logger.py receives native emits with correlation IDs and existing filters.

CI: The Rust test job installs the repo Python env (uv sync) so bridge logger integration tests can import litellm.

^{Reviewed by Cursor Bugbot for commit 89cc062. Bugbot is set up for automated code reviews on this repo. Configure here.}

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>

devin-ai-integration · 2026-09-22T23:12:38Z

I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".

Disable automatic comment, CI, and merge conflict monitoring

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>

codecov · 2026-09-22T23:16:43Z

Codecov Report

❌ Patch coverage is 67.85714% with 63 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
litellm/_logging.py	67.50%	39 Missing ⚠️
litellm/rust_bridge/logger.py	47.82%	12 Missing ⚠️
litellm/rust_bridge/diagnostics.py	63.33%	11 Missing ⚠️
litellm/litellm_core_utils/secret_redaction.py	92.30%	1 Missing ⚠️

📢 Thoughts on this report? Let us know!

greptile-apps · 2026-09-22T23:16:55Z

Confidence Score: 5/5

The PR appears safe to merge, with no outstanding correctness or repository-rule violations identified.

Findings

Bridge test silently passes ▶

Summary

This PR introduces a shared Rust diagnostics processor for log redaction and truncation, exposes it through the Python bridge, and routes native tracing events into LiteLLM’s existing Python logging infrastructure.

Adds the litellm-tracing crate and native diagnostic processing bindings.
Integrates native logging context across bridge execution and route machines.
Retains Python processing as the fallback when native processing is unavailable.
Updates Rust CI to install Python dependencies so the end-to-end bridge test executes rather than silently skipping.

_{Reviews (3) · Last reviewed commit: "ci(rust): install python deps so the log..."}

…absent Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>

codspeed · 2026-09-22T23:24:28Z

Merging this PR will not alter performance

✅ 31 untouched benchmarks

_{Comparing litellm_rust_logger (89cc062) with main (b4ccb5b)¹}

No successful run was found on main (38f0eb8) during the generation of this report, so b4ccb5b was used instead as the comparison base. There might be some changes unrelated to this pull request in this report. ↩

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>

…ilter Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>

mateo-berri · 2026-09-23T00:16:23Z

bugbot run

cursor

Stale Bugbot comment from a previous run.

…ey pattern The blanket REDACTED for a changed msg/color template discarded lines whose rendered form was already redacted by the same pipeline, e.g. 'password=%s' became 'REDACTED' instead of 'password=REDACTED'. Only fall back to REDACTED when the rendered form did not change either, which is where interpolation can mangle the key pattern the scrub would otherwise see. Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>

mateo-berri · 2026-09-23T00:38:52Z

bugbot run

mateo-berri · 2026-09-23T00:39:05Z

@greptileai

greptile-apps · 2026-09-23T00:42:53Z

+        if !importable {
+            eprintln!("SKIP: litellm package dependencies are not importable in this interpreter");
+            return;


Bridge test silently passes

When dotenv is unavailable, this test returns successfully. The Rust CI job does not install the Python package dependencies, so its only end-to-end logger bridge test passes without checking event delivery, correlation, level mapping, or handler failures. Please install the dependencies for this test or make their absence fail visibly

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

cursor

Stale Bugbot comment from a previous run.

The end-to-end bridge test skipped silently when litellm's Python deps were absent. uv sync --no-install-project installs them without a maturin build, and PYTHONPATH makes them visible to the embedded interpreter Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>

mateo-berri · 2026-09-23T01:06:29Z

bugbot run

mateo-berri · 2026-09-23T01:06:34Z

@greptileai

cursor

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit 89cc062. Configure here.}

yujonglee-berri and others added 3 commits September 22, 2026 23:09

feat(logger): add shared Rust diagnostics and Python logging bridge

1da4679

feat(logger): dispatch diagnostic processing through Rust

47e9239

chore: regenerate Cargo.lock after rebase

319f686

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>

devin-ai-integration Bot requested a review from a team September 22, 2026 23:12

devin-ai-integration Bot assigned yujonglee-berri Sep 22, 2026

devin-ai-integration Bot added the run-ci label Sep 22, 2026

yujonglee-berri and others added 2 commits September 22, 2026 23:16

test: allowlist bounded logging tree walkers in recursive detector

f78d2ed

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>

perf(logger): skip decoding plain access arguments

313ae45

yujonglee-berri and others added 2 commits September 22, 2026 23:22

test(logger): skip embedded-python logger test when litellm deps are …

23024f7

…absent Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>

style: cargo fmt

6de5633

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>

yujonglee-berri and others added 4 commits September 22, 2026 23:29

test: expect NativeDiagnosticProcessor in the native public surface

f3e6fec

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>

fix(stub): export NativeDiagnosticProcessor via __new__ in _native.pyi

95c420c

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>

refactor(tracing): rename logger crate and document host sink contract

c0d6a1e

test(logger): cover exc, stack, and nested extras in the diagnostic f…

cb68636

…ilter Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>

cursor Bot reviewed Sep 23, 2026

View reviewed changes

Comment thread litellm/_logging.py Outdated

greptile-apps Bot reviewed Sep 23, 2026

View reviewed changes

cursor Bot reviewed Sep 23, 2026

View reviewed changes

yujonglee-berri approved these changes Sep 23, 2026

View reviewed changes

yujonglee-berri merged commit b0ac23d into main Sep 23, 2026
98 of 99 checks passed

yujonglee-berri deleted the litellm_rust_logger branch September 23, 2026 01:44

mateo-berri mentioned this pull request Sep 23, 2026

fix(bedrock): stream /v1/messages Invoke bytes through instead of holding them in a 1024-byte chunker #42607

Merged

7 tasks done

Conversation

devin-ai-integration Bot commented Sep 22, 2026 • edited by cursor Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

TLDR

User Flow

Relevant issues

Affected release

Linear ticket

Pre-Submission checklist

Screenshots / Proof of Fix

Before (dd32715)

After (319f686)

Type

Caveats (if any)

Low

Validation

Final Attestation

Uh oh!

devin-ai-integration Bot commented Sep 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov Bot commented Sep 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

greptile-apps Bot commented Sep 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Confidence Score: 5/5

Findings

Summary

Uh oh!

codspeed Bot commented Sep 22, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will not alter performance

Footnotes

Uh oh!

mateo-berri commented Sep 23, 2026

Uh oh!

cursor Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mateo-berri commented Sep 23, 2026

Uh oh!

mateo-berri commented Sep 23, 2026

Uh oh!

greptile-apps Bot Sep 23, 2026

Choose a reason for hiding this comment

Uh oh!

cursor Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mateo-berri commented Sep 23, 2026

Uh oh!

mateo-berri commented Sep 23, 2026

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

devin-ai-integration Bot commented Sep 22, 2026 •

edited by cursor Bot

Loading

Before (`dd32715`)

After (`319f686`)

devin-ai-integration Bot commented Sep 22, 2026 •

edited

Loading

codecov Bot commented Sep 22, 2026 •

edited

Loading

greptile-apps Bot commented Sep 22, 2026 •

edited

Loading

codspeed Bot commented Sep 22, 2026 •

edited

Loading

cursor Bot left a comment •

edited

Loading

cursor Bot left a comment •

edited

Loading