Repository navigation
ci(codeql): exclude py/log-injection, which exceeds the 2 GiB result limit - #42318
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
…limit Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
|
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
TLDR
Problem this solves:
Analyze (python)CodeQL job fails on every push to mainpy/log-injection, exceeds CodeQL's 2 GiB result-set limit each timeHow it solves it:
py/log-injectionin.github/codeql/codeql-config.yml, next to the two queries already excluded for the same blowupUser Flow
Before: a contributor's PR shows a red CodeQL check that has nothing to do with their change
Analyze (python)failedQuery failed: codeql/python-queries/Security/CWE-117/LogInjection.ql (Result set is larger than the limit of 2GiB)and exit code 34After: the CodeQL check finishes and only goes red when a query finds something
Analyze (python)is greenRelevant issues
Affected release
Linear ticket
Pre-Submission checklist
Please complete all items before asking a LiteLLM maintainer to review your PR
uv run pytest tests/test_litellm/<your_test_file>.py -v. Leave the suites (make test-unit-*,make test-unit) to CI: it finishes in ~15 minutes where a laptop takes an hour or more@greptileaito re-request a review after pushing changes)Delays in PR merge?
If you're seeing a delay in your PR being merged, ping the LiteLLM Team on Slack (#pr-review).
Screenshots / Proof of Fix
Before (ecba48d, current main)
gh run list --workflow codeql.yml --branch main --event push --limit 200 --json conclusion --jq '[.[] | select(.conclusion=="success" or .conclusion=="failure")] | group_by(.conclusion) | map({(.[0].conclusion): length}) | add'{"failure":119}(zero successful push runs in the last 200)gh run view 35641153989 --log-failed | grep "Query failed"[168/168 eval 10m43s] Query failed: codeql/python-queries/Security/CWE-117/LogInjection.ql (Result set is larger than the limit of 2GiB).After (3d94d2b)
Analyze (python)check on this PR: it is the same job with the exclusion applied, link below once the run finishesType
🚄 Infrastructure
Caveats (if any)
Medium
Low
str(exception)keep a huge path set alive under diff-informed pruning), not proven. The exclude fixes both the main and PR failures regardlessFinal Attestation
Link to Devin session: https://app.devin.ai/sessions/d1426f073d0247599869ad3dc00ac65e
Open in Devin Desktop: https://app.devin.ai/desktop/session/d1426f073d0247599869ad3dc00ac65e?variant=devin