Repository navigation
test: migrate openai, openai_like and openrouter legacy tests to tests/unit - #42128
Merged
Merged
Conversation
…s/unit Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
Contributor
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
yuneng-berri
approved these changes
Sep 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR
Problem this solves:
tests/test_litellm, outside the mutation-proven unit harnessHow it solves it:
git mv'd to the mirrored path undertests/unit, 4 orphan__init__.pyremoved__init__.pyadded to the 17tests/unitdirectories this PR creates, so same-basename files cannot collide at collectionCounts: kept 221 / deleted 0 / rewritten 0 (239 node ids, 18 from parametrize)
moved 239, passed 239 in [REDACTED SECRET]/gh/BerriAI/litellm/2194947 (every node id from this PR is
passedin that job's junit)That job is red from 4 collection errors in files this PR does not touch:
base_llm/batches/test_transformation.py,fastcrw/search/test_transformation.py,nvidia_riva/audio_transcription/test_handler.pyandtest_transformation.pycollide by basename withanthropic/batches/on main (no__init__.py), all landed on main between 07:50 and 08:09 UTC before this branch's first unit run.installing_litellm_on_python*andgoogle_generate_content_endpoint_testingfail with the proxy master key boot check, which also fails on main (job 2194008)Now uncovered: nothing, no test was deleted
Per-test ledger
User Flow
No user-facing behavior changes, test-only move
Relevant issues
Wave 2 phase 11 of the legacy test migration, follows #42103
Affected release
Linear ticket
Pre-Submission checklist
Please complete all items before asking a LiteLLM maintainer to review your PR
uv run pytest tests/test_litellm/<your_test_file>.py -v. Leave the suites (make test-unit-*,make test-unit) to CI: it finishes in ~15 minutes where a laptop takes an hour or more@greptileaito re-request a review after pushing changes)Screenshots / Proof of Fix
Test-only move, proof is the CircleCI
unitjob junit linked above: 239 of 239 moved node ids passedLink to Devin session: https://app.devin.ai/sessions/791d8c04e1e94bfe847e05193a265e16
Open in Devin Desktop: https://app.devin.ai/desktop/session/791d8c04e1e94bfe847e05193a265e16?variant=devin