Repository navigation
test: migrate wave 1 phase 8 legacy llm tests to tests/unit - #42112
Conversation
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
|
Comments Outside DiffThese findings sit on lines the diff does not cover, so they could not be posted inline. Each one leaves this list once its file changes.
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
Re the SSL finding: the four |
|
Agreed. The four deleted tests violate the migration contract in |
|
@greptileai please re-review; the three coverage findings are resolved as intentional deletions under the migration contract (see thread replies above). |
TLDR
Problem this solves:
tests/test_litellm/llms/*files (wave 1, phase 8) sit outside the tiered test layoutHow it solves it:
git mv'd to the mirroredtests/unit/llms/...path, formatted with ruffCounts: kept 233 / deleted 7 / rewritten 0
moved 233, passed 233 in https://app.circleci.com/workflow/fd5b33f6-15ec-44cb-b283-7debd04ed5f9/job/2607904c-aca9-4f96-b507-416e25abd3aa (junit: 258 node ids incl. parametrized cases, 258 passed, 0 failed)
Now uncovered:
audio_urlcontent parts forwarded unchanged in hosted_vllm chat bodiesssl_verify=Falsereaches the sync httpx client for hosted_vllm chatssl_verify=Falsereaches the async httpx client for hosted_vllm chatssl_verify=Falsereaches the sync httpx client for hosted_vllm embeddingsssl_verify=Falsereaches the async httpx client for hosted_vllm embeddingsledger (240 tests)
User Flow
Test-only change; no user-facing behaviour changes.
Relevant issues
Follows #42103 (phase 0, CircleCI
unitjob).Affected release
Linear ticket
Pre-Submission checklist
Please complete all items before asking a LiteLLM maintainer to review your PR
uv run pytest tests/test_litellm/<your_test_file>.py -v. Leave the suites (make test-unit-*,make test-unit) to CI: it finishes in ~15 minutes where a laptop takes an hour or more@greptileaito re-request a review after pushing changes)Delays in PR merge?
If you're seeing a delay in your PR being merged, ping the LiteLLM Team on Slack (#pr-review).
Screenshots / Proof of Fix
After (4defed7)
LITELLM_LOCAL_MODEL_COST_MAP=True uv run pytest tests/unit -q -p no:cacheprovider→258 passeduv run ruff check tests/unit && uv run ruff format --check tests/unit→ cleangit status --short litellm/→ empty (all mutations restored)Type
✅ Test
Caveats (if any)
Low
google_generate_content_endpoint_testingfails identically on main (job 2194008: default master-key startup errors + Gemini 429); the threeinstalling_litellm_on_python*jobs failed on proxy startup (UnsafeMasterKeyError,localhost:4000refused) with no Python changes outsidetests/unitin this PRFinal Attestation
Link to Devin session: https://app.devin.ai/sessions/e170adc3f8354f4da4f5771c1148f808
Open in Devin Desktop: https://app.devin.ai/desktop/session/e170adc3f8354f4da4f5771c1148f808?variant=devin