Repository navigation
test(logging): add autorouter estimate keys to the GCS pub/sub spend-log golden - #42061
Merged
Merged
Conversation
…log golden Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Contributor
Author
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
Contributor
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
yuneng-berri
enabled auto-merge
September 20, 2026 02:22
yuneng-berri
approved these changes
Sep 20, 2026
3 of 5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR
Problem this solves:
logging_testingCI job fails on main intest_async_gcs_pub_sub_v1How it solves it:
autorouter_savings_estimateandautorouter_baseline_observationas null to the goldentest_spend_management_endpoints.pyUser Flow
Test-only change, no user-facing behavior changes
Relevant issues
Unblocks the
logging_testingjob on main, red since the autorouter baseline metadata keys started being stamped into every spend-log rowAffected release
Linear ticket
Pre-Submission checklist
Please complete all items before asking a LiteLLM maintainer to review your PR
uv run pytest tests/test_litellm/<your_test_file>.py -v. Leave the suites (make test-unit-*,make test-unit) to CI: it finishes in ~15 minutes where a laptop takes an hour or more@greptileaito re-request a review after pushing changes)Delays in PR merge?
If you're seeing a delay in your PR being merged, ping the LiteLLM Team on Slack (#pr-review).
Screenshots / Proof of Fix
Golden-file test fix, so the proof is the test itself
Before (1f28813)
LITELLM_LOCAL_MODEL_COST_MAP=True uv run --no-sync pytest tests/logging_callback_tests/test_gcs_pub_sub.py -q1 failed, 1 passed:Dictionary mismatch: ['Extra key in actual: metadata.autorouter_savings_estimate', 'Extra key in actual: metadata.autorouter_baseline_observation']After (144cf9a)
2 passedType
✅ Test
Caveats (if any)
Final Attestation
Link to Devin session: https://app.devin.ai/sessions/4b5ecf854386459db5a166663a7f642c
Open in Devin Desktop: https://app.devin.ai/desktop/session/4b5ecf854386459db5a166663a7f642c?variant=devin
Requested by: @mateo-berri