Repository navigation
test(fireworks_ai): stop pinning vision support on minimax-m3 - #41627
Conversation
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
|
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 6d20e68. Configure here.
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
TLDR
Problem this solves:
supports_vision: truefor minimax-m3How it solves it:
User Flow
Test-only change, no user-visible behavior
Relevant issues
Unblocks #41570
Affected release
Linear ticket
Pre-Submission checklist
uv run pytest tests/test_litellm/<your_test_file>.py -v. Leave the suites (make test-unit-*,make test-unit) to CI: it finishes in ~15 minutes where a laptop takes an hour or more@greptileaito re-request a review after pushing changes)Screenshots / Proof of Fix
Raw provider evidence, fetched today with a cache buster from
GET https://api.fireworks.ai/v1/serverless/models:The sync writes
supports_visionfrominput_modalities, so the catalog value is what the provider publishes. The tests pinned the oppositeThe changed tests pass against both the main catalog and the #41570 catalog:
Type
✅ Test
Caveats (if any)
Low
Link to Devin session: https://app.devin.ai/sessions/70717d80beaa4b07b193697a69f1e6a7
Open in Devin Desktop: https://app.devin.ai/desktop/session/70717d80beaa4b07b193697a69f1e6a7?variant=devin
Note
Low Risk
Test-only updates to Fireworks model metadata and vision helper coverage; no runtime or production behavior changes.
Overview
Test-only change so Fireworks catalog tests match provider-published
supports_visioninstead of hardcoding vision onminimax-m3.The shared Fireworks model-cost parametrization now uses
Noneforminimax-m3’s expected vision flag and only assertssupports_visionwhen that expectation is set. Vision behavior tests in the Fireworks chat transformation suite were retargeted fromminimax-m3tollama-v3p2-11b-vision-instruct(including_transform_messages_helperimage cases).This unblocks the price/catalog sync in PR #41570, where the Fireworks API reports
minimax-m3as text-only.Reviewed by Cursor Bugbot for commit 6d20e68. Bugbot is set up for automated code reviews on this repo. Configure here.