Repository navigation
test(e2e): drop the auto-router select "opens below" spec - #41568
Merged
yuneng-berri merged 1 commit intoSep 17, 2026
Merged
Conversation
The spec pinned Base UI's collision behaviour, not our code: it only passes while the template popup happens to fit under the trigger at 1280x900, and #41315's taller Add Auto Router form broke that premise for the second time in three weeks. #41527 tried to scroll the trigger into the upper half, but the dialog content is shorter than its max height, so nothing scrolls and CI still fails 3/3 with the trigger at y=487 The guarantee #38554 introduced is that the popup never covers the trigger, and the sibling spec keeps asserting that at a viewport with no room below
Contributor
|
yucheng-berri
approved these changes
Sep 17, 2026
yuneng-berri
deleted the
litellm_/ci-test-failures-investigation-99785b
branch
September 17, 2026 06:23
This was referenced Sep 17, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR
Problem this solves:
e2e_ui_testingis red on main since feat(ui): configure capability and Fuse v2 classifiers #41315 made the Add Auto Router form tallerHow it solves it:
User Flow
Before: a contributor opens any PR and CircleCI
e2e_ui_testingfails on a spec unrelated to their changerun-cilabele2e_ui_testingfailed after 3 attempts oftests/modelsPage/autoRouterTemplateSelect.spec.ts"opens the options below the trigger when there is room below it", withExpected: < 450, Received: 487After: the same PR's
e2e_ui_testingis green and the select still behaves the same wayrun-cilabele2e_ui_testingpasses;autoRouterTemplateSelect.spec.tsnow runs one test, "keeps the trigger uncovered when the options open with no room below it"Relevant issues
Affected release
Linear ticket
Pre-Submission checklist
Please complete all items before asking a LiteLLM maintainer to review your PR
uv run pytest tests/test_litellm/<your_test_file>.py -v. Leave the suites (make test-unit-*,make test-unit) to CI: it finishes in ~15 minutes where a laptop takes an hour or more@greptileaito re-request a review after pushing changes)Delays in PR merge?
If you're seeing a delay in your PR being merged, ping the LiteLLM Team on Slack (#pr-review).
Screenshots / Proof of Fix
Both runs use the CircleCI harness locally:
tests/e2e/ui/run_e2e.shboots a fresh Postgres, builds the dashboard from source, starts the mock LLM server and the proxy ontests/e2e/ui/fixtures/config.yml, then runs Playwright with the CI settings (--workers=1 --retries=2)Before (5ef40a6)
bash tests/e2e/ui/run_e2e.sh --workers=1 --retries=2 --reporter=listAfter (25445e8)
bash tests/e2e/ui/run_e2e.sh tests/modelsPage/autoRouterTemplateSelect.spec.ts --reporter=listType
✅ Test
Caveats (if any)
Low
QA runbook
Final Attestation