Skip to content

test(e2e): read a deleted key back as deleted, not as a 404 #41551

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yuneng-berri merged 1 commit into from
Sep 17, 2026
Merged

test(e2e): read a deleted key back as deleted, not as a 404 #41551

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 2 additions & 11 deletions tests/e2e/management/test_key_lifecycle_e2e.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
import pytest

from e2e_config import unique_marker
from e2e_http import Result, StreamingResponse, Success, UnknownApiError, unwrap
from e2e_http import Result, StreamingResponse, Success, unwrap
from lifecycle import ResourceManager
from management_client import MODEL_ACCESS_DENIED_MARKER, ManagementClient
from models import (
Expand Down Expand Up @@ -135,10 +135,6 @@ def converged(result: Result[KeyInfoResponse]) -> bool:
return MappingProxyType({replica: unwrap(read).info for replica, read in reads.items()})


def _is_key_not_found(result: Result[KeyInfoResponse]) -> bool:
return isinstance(result, UnknownApiError) and result.status_code == 404


def _assert_reads_back(info: KeyInfo, expected: KeyGenerateBody, replica: str) -> None:
for field, observed, wanted in (
("key_alias", info.key_alias, expected.key_alias),
Expand Down Expand Up @@ -290,10 +286,5 @@ def test_delete_revokes_info_and_chat_on_every_replica(

client.delete_key_strict(created.key)

_ = client.proxy.read_back_everywhere(
"/key/info",
params=KeyInfoParams(key=created.key),
response_type=KeyInfoResponse,
converged=_is_key_not_found,
)
_ = _key_info_everywhere(client, created.key, lambda info: info.status == "deleted")
_assert_chat_rejected_everywhere(client, created.key, mock_deployment)
1 change: 1 addition & 0 deletions tests/e2e/models.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,6 +136,7 @@ class LiteLLMBudgetTable(BaseModel):

class KeyInfo(BaseModel):
key_alias: str | None = None
status: str | None = None
metadata: KeyMetadata | None = None
models: list[str] = []
tpm_limit: int | None = None
Expand Down
Loading