Repository navigation
fix(prices): dedupe Nova cache_read_input_token_cost keys left by a text merge - #41496
Merged
Merged
Conversation
…ext merge PR #41343 and PR #41112 both added cache_read_input_token_cost to the six amazon.nova-{micro,lite,pro}-v1:0 and us.amazon.nova-* entries, one at the top of each entry and one at the bottom. The merge kept both, so every PR now fails test_price_map_has_no_duplicate_keys. Both copies carried the same value, so this only removes the trailing duplicate in both price files
yuneng-berri
requested review from
kerry-berri,
mateo-berri and
ryan-crabbe-berri
as code owners
September 16, 2026 21:59
Contributor
Greptile SummaryRemoves six duplicate
Confidence Score: 5/5This PR appears safe to merge, with no actionable issues identified The removed keys duplicate retained values, both pricing maps stay synchronized, and existing tests explicitly detect duplicate keys in both files Important Files Changed
Reviews (1): Last reviewed commit: "fix(prices): dedupe Nova cache_read_inpu..." | Re-trigger Greptile |
Contributor
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
yuneng-berri
added a commit
that referenced
this pull request
Sep 16, 2026
…ext merge Six Amazon Nova entries define cache_read_input_token_cost twice, which is what a clean text merge of two branches that both added the field looks like. JSON parsers keep the last occurrence, so this turned test_price_map_has_no_duplicate_keys red on every open PR's merge commit, including this one, which touches neither file. Both occurrences in all six entries carry the same value, so dropping the later one leaves every parsed price identical. Same change as #41496, carried here so this branch is not blocked on it. Identical deletions, so the two merge cleanly in either order.
yuneng-berri
force-pushed
the
litellm_/litellm-ci-failure-be9267
branch
from
September 16, 2026 22:35
26390a0 to
a6b10ad
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR
Problem this solves:
cache_read_input_token_costtwicetest_price_map_has_no_duplicate_keysfails on main, so every PR's Unit Tests job is redHow it solves it:
User Flow
Before: a contributor pushes any branch against main and the Unit Tests workflow goes red on a file they never touched
misc / Run testsjob fails withtest_price_map_has_no_duplicate_keys[main]and[backup]reportingcache_read_input_token_costlisted twice, six times eachAfter: the same push goes green
misc / Run testsjob passes: each Nova entry carriescache_read_input_token_costonceRelevant issues
#41343 and #41112 both added
cache_read_input_token_costtoamazon.nova-{micro,lite,pro}-v1:0andus.amazon.nova-{micro,lite,pro}-v1:0, one at the top of each entry and one at the bottom. Neither branch had the duplicate on its own. Merging #41112 (6edb549) onto a main that already had #41343 kept both linesAffected release
Linear ticket
Pre-Submission checklist
Please complete all items before asking a LiteLLM maintainer to review your PR
uv run pytest tests/test_litellm/<your_test_file>.py -v. Leave the suites (make test-unit-*,make test-unit) to CI: it finishes in ~15 minutes where a laptop takes an hour or more@greptileaito re-request a review after pushing changes)Delays in PR merge?
If you're seeing a delay in your PR being merged, ping the LiteLLM Team on Slack (#pr-review).
Screenshots / Proof of Fix
The duplicated lines carried the same value as the line they duplicated, so a request through the proxy prices identically before and after. The only observable is the schema gate itself
Before (f62f140)
PYTHONPATH=$PWD python -m pytest tests/test_litellm/test_model_prices_schema.py -k test_price_map_has_no_duplicate_keys -qAfter (a6b10ad)
PYTHONPATH=$PWD python -m pytest tests/test_litellm/test_model_prices_schema.py -qPYTHONPATH=$PWD python -m pytest tests/test_litellm/llms/bedrock/test_cross_region_inference_profile_mapping.py tests/test_litellm/llms/bedrock/chat/test_converse_transformation.py -k nova -qType
🐛 Bug Fix
Caveats (if any)
Low
test_price_map_has_no_duplicate_keysalready guards this and is the test that caught itMock(spec=...)tests inllm_responses_api_testingbroken by fix(responses): recount tokens when a streamed response completes without usage #41337, the integration harness's 404 expectation superseded by feat(keys): filter /key/list by active, expired, revoked or deleted status and serve deleted keys from /key/info #41311, plus a long-standing cooldown test and a CI-only Sumo Logic count