Repository navigation
fix(hosted-vllm): preserve reasoning_content in assistant history - #41396
RishikeshVepura wants to merge 9 commits into
Conversation
…ticated requests Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
…stency Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
…nd Model Hub UI Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
…mutation Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
…ow read fails Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
…iption feat(model_hub): surface model_info.description in Model Hub
…ip_save_on_failed_read fix(health): skip background health check DB writes when the latest-row read fails
feat(dd_span_tagger): emit litellm.user_email span tag for JWT-authenticated requests
Greptile SummaryPreserves Confidence Score: 5/5The PR appears safe to merge, with the targeted behavior covered through the production transformation path No actionable failures remain. The change directly removes the field deletion responsible for lost reasoning history, and the updated assertion would fail on the prior implementation Important Files Changed
Reviews (1): Last reviewed commit: "fix(hosted-vllm): preserve reasoning_con..." | Re-trigger Greptile |
|
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
Closing as a duplicate of #43599, which carries the same hosted_vllm reasoning_content fix and merges cleanly against main. Thanks for the fix |
TLDR
Problem this solves:
How it solves it:
User Flow
Before: a developer’s tool-calling agent loses prior reasoning on its next turn
After: the same agent retains prior reasoning on its next turn
Relevant issues
Related to the Fireworks reasoning-content regression, but this affects the separate
hosted_vllmprovider transformation.Affected release
Regression in v1.100.0
Linear ticket
Pre-Submission checklist
11 passedmake lintpasses locally@greptileaito re-request a review after pushing changes)Screenshots / Proof of Fix
Before
After
Type
🐛 Bug Fix
Caveats (if any)
Final Attestation