refactor(lint): allow dict and mapping annotations in LIT001 by devin-ai-integration[bot] · Pull Request #41100 · BerriAI/litellm

devin-ai-integration · 2026-09-14T18:23:53Z

Relevant issues

Pre-Submission checklist

Please complete all items before asking a LiteLLM maintainer to review your PR

I have Added testing in the tests/test_litellm/ directory, Adding at least 1 test is a hard requirement
I have added a screenshot of my new test passing locally
My PR passes all unit tests on make test-unit
My PR's scope is as isolated as possible, it only solves 1 specific problem

Type

🧹 Refactoring

Changes

Main already retired LIT002 in #43971, so this PR is now the remaining half of the LIT002 cleanup: LIT001 stops flagging mapping annotations

 MUTABLE_COLLECTIONS = frozenset((
-    "dict", "list", "set", "Dict", "List", "DefaultDict", "OrderedDict", "Counter",
-    "Deque", "ChainMap", "deque", "defaultdict", "MutableMapping", "MutableSequence", "MutableSet",
+    "list", "set", "List", "Deque", "deque", "MutableSequence", "MutableSet",
 ))

So x: dict[str, int] and payload: MutableMapping[str, object] are clean, while x: dict[str, list[int]] still trips on the nested list. The LIT001 message and docstring now recommend Sequence / AbstractSet / tuple / frozenset instead of also pushing Mapping

Once dict is allowed, LIT013 flags every # mutable-ok that only covered a mapping annotation as suppressing nothing, so 945 of them across 269 files are deleted. Those are comment-only edits; the eight test files that ruff format also touched were already unformatted on main and CI's scoped format check requires them clean

AGENTS.md: the LIT001 paragraph and the no-mutation convention now say plain dict is fine (most of the ecosystem takes and returns dicts, MappingProxyType at every boundary costs more than it protects), prefer tuples over lists and frozensets over sets, prefer frozen dataclasses or ReadOnly TypedDicts for structured records, and never deep copy a value just to hand out an immutable view (the self-referential breadcrumbs deep copy that leaked memory is the motivating case)

Why: the dict ban filled files with # mutable-ok noise, pushed defensive deep copies and MappingProxyType round trips at every library boundary, and made the LIT budget ratchet turn unrelated rebases red because almost every real PR adds a dict literal. The narrower rule on sequences and sets keeps the part of the policy that cost little

Not in scope: caches that shallow copy on every mutation and per-folder scoping of the rule, both discussed as follow ups

Tests

tests/unit/test_check_type_discipline.py gains test_mapping_annotations_are_allowed (dict, Dict, DefaultDict, MutableMapping, defaultdict, OrderedDict, string forward ref all clean; dict[str, list[int]] still flagged) and the existing LIT001 cases switch their dict fixtures to list/set so they keep testing the rule

uv run pytest tests/unit/test_check_type_discipline.py -q
137 passed in 1.20s
uv run python scripts/type_discipline_gate.py
OK: no LIT rule grew past its merge-base count (base origin/main)
uv run python scripts/check_type_discipline.py litellm/ tests/ scripts/ | grep -c LIT013
0

Review state

Greptile 5/5 and Bugbot no new issues at 82ba2a2, both re-triggered on each push. Required checks green. rust-wheel is red on main too: tests/test_litellm_rust/test_traces.py fails to collect with No module named scripts, and this PR touches nothing under tests/test_litellm_rust, scripts/seed_tracing_fixtures.py, or the Makefile

Link to Devin session: https://app.devin.ai/sessions/db4d9941966544268db903dcf292d47b
Open in Devin Desktop: https://app.devin.ai/desktop/session/db4d9941966544268db903dcf292d47b?variant=devin

Note

Low Risk
Lint policy and comment cleanup only; runtime logic is unchanged aside from narrower LIT001 enforcement on sequences and sets.

Overview
LIT001 no longer treats mapping types as mutable collections: dict, Dict, MutableMapping, defaultdict, OrderedDict, and similar annotations are allowed, while nested mutable containers (e.g. dict[str, list[int]]) still fail on the inner list/set.

Because many # mutable-ok comments only existed to excuse dict-typed parameters and locals, this PR strips hundreds of those suppressions (and a few related # rebind-ok notes) across harness, integrations, LLM providers, caching, and enterprise code—comment-only in those files, with no intended behavior change.

AGENTS.md is updated to match: plain dict is acceptable at boundaries; prefer tuples/frozensets over lists/sets; use frozen dataclasses or ReadOnly TypedDicts for structured records; avoid deep copies solely to expose an immutable view.

Unit coverage adds test_mapping_annotations_are_allowed and adjusts existing LIT001 fixtures to use list/set where dict was previously the example.

^{Reviewed by Cursor Bugbot for commit d14859c. Bugbot is set up for automated code reviews on this repo. Configure here.}

devin-ai-integration · 2026-09-14T18:23:57Z

🤖 Devin AI Engineer

I'll be helping with this pull request! Here's what you should know:

✅ I will automatically:

Address comments on this PR. Add '(aside)' to your comment to have me ignore it.
Look at CI failures and help fix them

Note: I can only respond to comments from users who have write access to this repository.

⚙️ Control Options:

Disable automatic comment, CI, and merge conflict monitoring

codspeed · 2026-09-14T18:26:16Z

Merging this PR will not alter performance

✅ 31 untouched benchmarks

_{Comparing litellm_remove_lit002_dict_ban (d14859c) with main (ee47da3)}

codecov · 2026-09-14T18:27:00Z

Codecov Report

❌ Patch coverage is 88.50575% with 40 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
litellm/harness/handlers/deepagents_handler.py	10.00%	9 Missing ⚠️
litellm/proxy/policy_engine/pipeline_executor.py	11.11%	8 Missing ⚠️
litellm/llms/deepagents/harness/sandbox_backend.py	0.00%	5 Missing ⚠️
litellm/proxy/utils.py	54.54%	5 Missing ⚠️
litellm/router.py	54.54%	5 Missing ⚠️
litellm/harness/sync.py	0.00%	1 Missing ⚠️
litellm/llms/claude_code/harness/transformation.py	66.66%	1 Missing ⚠️
litellm/proxy/lens/inference.py	0.00%	1 Missing ⚠️
litellm/proxy/litellm_pre_call_utils.py	50.00%	1 Missing ⚠️
...ass_through_endpoints/llm_passthrough_endpoints.py	0.00%	1 Missing ⚠️
... and 3 more

📢 Thoughts on this report? Let us know!

mateo-berri · 2026-09-14T18:29:25Z

@greptile-apps

greptile-apps · 2026-09-14T18:32:58Z

Confidence Score: 5/5

[Low impact] The PR appears safe to merge; no new actionable issue remains

Summary

LIT001 now allows mapping annotations while keeping its checks for mutable sequences and sets

LIT001 allows mappings but still flags mutable sequences and sets.
Many # mutable-ok comments disappear as mapping annotations stop needing exceptions.

The earlier _invoke_sdk comment was dismissed by devin-ai-integration[bot] because the mutation already existed on main. The retry-loop comment was correctly disputed by devin-ai-integration[bot] and conceded by Greptile. The stale mapping examples are fixed

_{Reviews (14) · Last reviewed commit: "chore: merge main into litellm_remove_li..." · Reviewed by Greptile}

mateo-berri · 2026-09-14T18:35:45Z

bugbot run

cursor

Stale Bugbot comment from a previous run.

Main already retired LIT002 (#43971). This narrows LIT001 to mutable sequences and sets, so dict, Dict, DefaultDict, OrderedDict, Counter, ChainMap, defaultdict and MutableMapping annotations are allowed, nested list/set inside a mapping still trips, and the 945 mutable-ok suppressions that only covered mapping annotations are deleted (LIT013 now flags them). AGENTS.md guidance updated to match Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>

mateo-berri · 2026-10-07T17:12:21Z

@greptileai review

mateo-berri · 2026-10-07T17:22:24Z

bugbot run

cursor

Stale Bugbot comment from a previous run.

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>

…m main Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>

mateo-berri · 2026-10-07T21:08:08Z

@greptileai review

mateo-berri · 2026-10-07T21:08:10Z

bugbot run

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>

mateo-berri · 2026-10-07T21:10:37Z

@greptileai review

mateo-berri · 2026-10-07T21:10:38Z

bugbot run

cursor

Stale Bugbot comment from a previous run.

greptile-apps · 2026-10-08T00:34:23Z

Comments Outside Diff

These findings could not be posted inline.

Lens service port is unresolved helm/litellm/templates/lens/service.yaml:17 ▶

When Lens is enabled in the litellm chart, this Service targets the named port otlp, but the Lens container does not declare a port with that name. Kubernetes therefore cannot resolve the Service target port, so traffic from the Lens ingress or gateway cannot reach the worker.

mateo-berri · 2026-10-08T00:58:39Z

@greptileai review. The three Lens Helm findings come from main commits merged in 0be8fd5; this PR diff vs merge base touches no helm or lens files

…_dict_ban_v2 Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> # Conflicts: # litellm/types/decisions.py

mateo-berri · 2026-10-08T05:00:19Z

@greptileai review

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>

mateo-berri · 2026-10-08T05:11:19Z

@greptileai review

mateo-berri · 2026-10-08T05:42:31Z

bugbot run

mateo-berri · 2026-10-08T05:43:05Z

@greptileai review

cursor

Stale Bugbot comment from a previous run.

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>

mateo-berri · 2026-10-09T02:12:07Z

@greptileai

mateo-berri · 2026-10-09T02:12:09Z

bugbot run

cursor

Stale Bugbot comment from a previous run.

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>

mateo-berri · 2026-10-09T02:41:20Z

@greptileai

mateo-berri · 2026-10-09T02:41:21Z

bugbot run

cursor

Stale Bugbot comment from a previous run.

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>

mateo-berri · 2026-10-09T07:18:48Z

@greptileai

mateo-berri · 2026-10-09T07:18:48Z

bugbot run

cursor

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit d14859c. Configure here.}

mateo-berri · 2026-10-09T08:09:38Z

@greptileai review

devin-ai-integration Bot requested a review from a team September 14, 2026 18:23

devin-ai-integration Bot assigned mateo-berri Sep 14, 2026

devin-ai-integration Bot had a problem deploying to e2e-changed September 14, 2026 18:24 Error

github-advanced-security Bot found potential problems Sep 14, 2026

View reviewed changes

Comment thread litellm/proxy/management_endpoints/team_endpoints.py Fixed

cursor Bot reviewed Sep 14, 2026

View reviewed changes

Comment thread litellm/litellm_core_utils/llm_response_utils/convert_dict_to_response.py

devin-ai-integration Bot had a problem deploying to e2e-changed September 14, 2026 21:26 Error

devin-ai-integration Bot had a problem deploying to e2e-changed September 14, 2026 22:12 Error

devin-ai-integration Bot had a problem deploying to e2e-changed September 15, 2026 00:27 Error

devin-ai-integration Bot requested a deployment to e2e-changed September 15, 2026 07:59 Waiting

devin-ai-integration Bot force-pushed the litellm_remove_lit002_dict_ban branch from 6b847ee to 22d584a Compare October 7, 2026 17:11

devin-ai-integration Bot had a problem deploying to e2e-changed October 7, 2026 17:11 Error

devin-ai-integration Bot changed the title ~~refactor(lint): retire LIT002 and allow dict annotations in LIT001~~ refactor(lint): allow dict and mapping annotations in LIT001 Oct 7, 2026

cursor Bot reviewed Oct 7, 2026

View reviewed changes

mateo-berri and others added 2 commits October 7, 2026 21:06

chore: merge main into litellm_remove_lit002_dict_ban

9db1199

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>

chore(lint): drop two mapping-only mutable-ok suppressions merged fro…

71bb4c0

…m main Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>

mateo-berri and others added 2 commits October 7, 2026 21:10

chore: merge main into litellm_remove_lit002_dict_ban

6b87daf

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>

chore(lint): drop mapping-only mutable-ok suppressions merged from main

bb4cd5c

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>

cursor Bot reviewed Oct 8, 2026

View reviewed changes

Merge remote-tracking branch 'origin/main' into litellm_remove_lit002…

22003cf

…_dict_ban_v2 Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> # Conflicts: # litellm/types/decisions.py

devin-ai-integration Bot had a problem deploying to e2e-changed October 8, 2026 05:00 Error

greptile-apps Bot reviewed Oct 8, 2026

View reviewed changes

Comment thread litellm/harness/endpoint.py

refactor(lint): drop stale mutable-ok suppressions in managed_files

09327f6

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>

devin-ai-integration Bot had a problem deploying to e2e-changed October 8, 2026 05:11 Error

cursor Bot reviewed Oct 8, 2026

View reviewed changes

chore: merge main into litellm_remove_lit002_dict_ban

398a8b1

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>

devin-ai-integration Bot had a problem deploying to e2e-changed October 9, 2026 02:11 Error

cursor Bot reviewed Oct 9, 2026

View reviewed changes

greptile-apps Bot reviewed Oct 9, 2026

View reviewed changes

Comment thread litellm-proxy-extras/litellm_proxy_extras/utils.py

Comment thread scripts/check_type_discipline.py Outdated

docs(lint): list sequence examples in mutable_names_in docstring

82ba2a2

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>

devin-ai-integration Bot had a problem deploying to e2e-changed October 9, 2026 02:41 Error

cursor Bot reviewed Oct 9, 2026

View reviewed changes

chore: merge main into litellm_remove_lit002_dict_ban

d14859c

Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>

devin-ai-integration Bot requested a deployment to e2e-changed October 9, 2026 07:18 Waiting

cursor Bot reviewed Oct 9, 2026

View reviewed changes

Conversation

devin-ai-integration Bot commented Sep 14, 2026 • edited by cursor Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Relevant issues

Pre-Submission checklist

Type

Changes

Tests

Review state

Uh oh!

devin-ai-integration Bot commented Sep 14, 2026

🤖 Devin AI Engineer

Uh oh!

codspeed Bot commented Sep 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will not alter performance

Uh oh!

codecov Bot commented Sep 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

mateo-berri commented Sep 14, 2026

Uh oh!

Uh oh!

greptile-apps Bot commented Sep 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Confidence Score: 5/5

Summary

Uh oh!

mateo-berri commented Sep 14, 2026

Uh oh!

cursor Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

mateo-berri commented Oct 7, 2026

Uh oh!

mateo-berri commented Oct 7, 2026

Uh oh!

cursor Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mateo-berri commented Oct 7, 2026

Uh oh!

mateo-berri commented Oct 7, 2026

Uh oh!

mateo-berri commented Oct 7, 2026

Uh oh!

mateo-berri commented Oct 7, 2026

Uh oh!

cursor Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot commented Oct 8, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Comments Outside Diff

Uh oh!

mateo-berri commented Oct 8, 2026

Uh oh!

mateo-berri commented Oct 8, 2026

Uh oh!

Uh oh!

mateo-berri commented Oct 8, 2026

Uh oh!

mateo-berri commented Oct 8, 2026

Uh oh!

mateo-berri commented Oct 8, 2026

Uh oh!

cursor Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mateo-berri commented Oct 9, 2026

Uh oh!

mateo-berri commented Oct 9, 2026

Uh oh!

cursor Bot left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

devin-ai-integration Bot commented Sep 14, 2026 •

edited by cursor Bot

Loading

codspeed Bot commented Sep 14, 2026 •

edited

Loading

codecov Bot commented Sep 14, 2026 •

edited

Loading

greptile-apps Bot commented Sep 14, 2026 •

edited

Loading

cursor Bot left a comment •

edited

Loading

cursor Bot left a comment •

edited

Loading

cursor Bot left a comment •

edited

Loading

greptile-apps Bot commented Oct 8, 2026 •

edited

Loading

cursor Bot left a comment •

edited

Loading

cursor Bot left a comment •

edited

Loading

cursor Bot left a comment •

edited

Loading