Repository navigation
chore(ui): regenerate schema.d.ts after soft_budget left the user endpoint docstrings - #40987
devin-ai-integration[bot] wants to merge 1 commit into
Conversation
…point docstrings Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
Greptile SummaryThis PR synchronizes the generated TypeScript OpenAPI declarations with the proxy endpoint documentation
Confidence Score: 5/5The PR appears safe to merge because it only corrects stale generated comments to match the authoritative endpoint documentation The removed comments describe a field that is absent from the current user request models and endpoint docstrings, so no behavioral or contract regression remains
|
| Filename | Overview |
|---|---|
| ui/litellm-dashboard/src/lib/http/schema.d.ts | Removes two stale generated documentation lines without changing the API types |
Reviews (1): Last reviewed commit: "chore(ui): regenerate schema.d.ts after ..." | Re-trigger Greptile
…point docstrings Keeps the UI API types sync check green on this branch. Identical to the regeneration in BerriAI#40987.
…ires Both checks are red on main. The schema.d.ts change matches BerriAI#40987 and the test reorder matches BerriAI#41011
|
Closing: main already has schema.d.ts in sync (gen:api on cab1e11 yields no diff), only litellm_internal_staging was stale |
TLDR
Problem this solves:
soft_budgetfrom the/user/newand/user/updatedocstringsschema.d.tsstill has those two lineslitellm/proxy/now fails "Verify schema.d.ts matches the proxy OpenAPI spec"How it solves it:
npm run gen:apiinui/litellm-dashboard, commit the resultUser Flow
Before: a contributor opens a PR that touches any proxy file and the schema sync check fails on lines they never touched
litellm/proxy/soft_budgetfrom the user endpoint descriptionsnpm run gen:apilocally and get the same two line diff, unrelated to their changeAfter: the same PR passes the schema sync check
litellm/proxy/npm run gen:apilocally produces no diffRelevant issues
Unblocks the CI on #40922
Affected release
Linear ticket
Pre-Submission checklist
Please complete all items before asking a LiteLLM maintainer to review your PR
uv run pytest tests/test_litellm/<your_test_file>.py -v. Leave the suites (make test-unit-*,make test-unit) to CI: it finishes in ~15 minutes where a laptop takes an hour or more@greptileaito re-request a review after pushing changes)Delays in PR merge?
If you're seeing a delay in your PR being merged, ping the LiteLLM Team on Slack (#pr-review).
Screenshots / Proof of Fix
Before (c2c2a62, current
litellm_internal_staging)cd ui/litellm-dashboard && npm run gen:api->git diff --statshowsui/litellm-dashboard/src/lib/http/schema.d.ts | 2 --- soft_budget: Optional[float] - Get alerts when user crosses given budget, doesn't block requests.under/user/newand/user/updateAfter (842864f)
cd ui/litellm-dashboard && npm run gen:api->git diff --statprints nothingVerify schema.d.ts matches the proxy OpenAPI speccheck on this PR passes (job 103701407579), which is the live proofNo UI change: the two lines are doc comments inside
schema.d.ts, nothing the dashboard rendersType
🧹 Refactoring
Caveats (if any)
Low
inspect.cleandocnormalization), so the output matches CI byte for byteReview and CI status (at 842864f)
Final Attestation
/live-pr-risk not run: the diff is two doc comment lines in a generated TypeScript file, there is no runtime behavior to A/B
Link to Devin session: https://app.devin.ai/sessions/42a8e9b831c141108fd010826df31fe7
Open in Devin Desktop: https://app.devin.ai/desktop/session/42a8e9b831c141108fd010826df31fe7?variant=devin
Requested by: @yucheng-berri