Skip to content

fix(ci): update OCR lifecycle test path - #40926

Closed
yuneng-berri wants to merge 1 commit into
litellm_internal_stagingfrom
litellm_fix_ocr_ci_test_selection
Closed

yuneng-berri wants to merge 1 commit into
litellm_internal_stagingfrom
litellm_fix_ocr_ci_test_selection

Conversation

@yuneng-berri

@yuneng-berri yuneng-berri commented Sep 13, 2026 •

Copy link
Copy Markdown
Contributor

TLDR

Problem this solves:

How it solves it:

  • Select the replacement OCR lifecycle tests
  • Keep the existing provider tests and parallel execution

User Flow

Before: a contributor opens the OCR CI job and sees zero tests run

  1. Open the CircleCI workflow for a staging change
  2. Open ocr_testing
  3. See 4 workers [0 items] and missing coverage warnings

After: the contributor gets OCR test results from the same job

  1. Open the CircleCI workflow for a staging change
  2. Open ocr_testing
  3. See provider and lifecycle tests execute

Relevant issues

Failed OCR job

Linear ticket

Pre-Submission checklist

  • I have added meaningful tests
  • The handful of test files covering my change pass locally
  • My PR passes all required CI/CD checks
  • My PR's scope is as isolated as possible
  • Greptile has independently posted 5/5 for the current head

Existing lifecycle coverage passes: 23 tests. The complete job selection collects 56 tests. CircleCI configuration validation passes. Local verification used Python 3.13; CI runs Python 3.12. The scoped local lint entrypoint has no checks for this configuration-only change

Screenshots / Proof of Fix

Before (d4a72e7)

  1. Open OCR job 2174652
  2. Expand Run tests: 4 workers [0 items], no tests ran in 30.38s, then exit status 123

After (f5a7b54)

  1. Open OCR job 2174770
  2. Expand Run tests: 4 workers [56 items]; 48 passed and 8 skipped
  3. Confirm the job succeeded, including coverage rename, test-results upload, and workspace persistence

Type

Bug Fix
Infrastructure

Caveats (if any)

Low

  • Eight OCR tests remain skipped in CI
  • Other repository checks are still running

Final Attestation

  • The tests check the right things, including the edge cases, and regressions in the respective real-world customer use-cases are not possible after this PR

@yuneng-berri
yuneng-berri requested a review from a team September 13, 2026 00:19
@greptile-apps

greptile-apps Bot commented Sep 13, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Updates the OCR CircleCI job to select the current Rust bridge lifecycle test file instead of a deleted test path

  • Preserves the existing OCR provider-test glob
  • Preserves parallel CircleCI test execution
  • Selects an existing lifecycle test module without duplicate glob coverage

Confidence Score: 5/5

The PR appears safe to merge because the updated CI path exists, is collectable, and does not duplicate the existing OCR test glob

The only change repairs the OCR job’s explicit test selection while retaining its provider tests and parallel execution, with no concrete regression identified

Important Files Changed

Filename Overview
.circleci/config.yml Replaces a deleted OCR lifecycle test path with the existing, collectable Rust bridge lifecycle test module

Reviews (1): Last reviewed commit: "fix(ci): update OCR lifecycle test path" | Re-trigger Greptile

@codecov

codecov Bot commented Sep 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants