fix(terraform): mark litellm_key partial when /key/update rejects the request

[cursor]

TLDR

Problem this solves:

• A rejected /key/update still persisted the bad planned values into Terraform state, so the next terraform plan showed no drift and the update was silently dropped
• TestResourceKeyUpdateFailureKeepsPriorState (added in fix(terraform): keep prior state when a virtual key update is rejected #40512) started failing on litellm_internal_staging after the merge landed the guard in the wrong branch

How it solves it:

• Call d.Partial(true) in the c.UpdateKey error path too, not only on plannedKeyMetadata failures

User Flow

Before: a Terraform user who typos budget_duration = "bad" on a litellm_key sees the apply fail and then loses the guard on retries

1. They run terraform apply on a litellm_key with budget_duration = "bad"
2. The proxy 400s with Invalid budget_duration 'bad' and the apply fails
3. They fix the typo to budget_duration = "30d" and run terraform plan again
4. The plan reports no changes, the key on the proxy still has no budget_duration set, and the fix is silently dropped

After: the same user's retry actually applies the corrected value

1. They run terraform apply on a litellm_key with budget_duration = "bad"
2. The proxy 400s with Invalid budget_duration 'bad' and the apply fails
3. They fix the typo to budget_duration = "30d" and run terraform plan again
4. The plan shows budget_duration changing from "" to "30d" and the next apply pushes it to the proxy

Relevant issues

Linear ticket

Pre-Submission checklist

• I have added meaningful tests (the regression test from fix(terraform): keep prior state when a virtual key update is rejected #40512 now actually exercises the fixed path)
• The handful of test files covering my change pass locally
• My PR passes all required CI/CD checks
• My PR's scope is as isolated as possible; it only solves 1 specific problem

Screenshots / Proof of Fix

Before (5264f8e)

1. cd terraform/provider && go test -timeout 60s -run TestResourceKeyUpdateFailureKeepsPriorState ./...
2. Output:

   --- FAIL: TestResourceKeyUpdateFailureKeepsPriorState (0.00s)
       resource_key_test.go:356: failed update persisted budget_duration="bad" into state, want it absent
   FAIL	github.com/BerriAI/terraform-provider-litellm/litellm	0.007s
   

After (ff8e0f8)

1. cd terraform/provider && go test -timeout 120s ./...
2. Output:

   ?   	github.com/BerriAI/terraform-provider-litellm	[no test files]
   ok  	github.com/BerriAI/terraform-provider-litellm/litellm	5.079s
   ok  	github.com/BerriAI/terraform-provider-litellm/tools/endpointaudit	0.003s
   

Type

🐛 Bug Fix

Final Attestation

• The tests check the right things, including the edge cases, and regressions in the respective real-world customer use-cases are not possible after this PR

  

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!