Skip to content

fix(proxy): increase spend counter cache capacity #40233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wzj1228516103 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(proxy): increase spend counter cache capacity #40233

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion litellm/proxy/proxy_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,6 +240,7 @@ def generate_feedback_box():
from litellm import Router
from litellm._logging import _redact_string, verbose_proxy_logger, verbose_router_logger
from litellm.caching.caching import DualCache, RedisCache
from litellm.caching.in_memory_cache import InMemoryCache
from litellm.caching.redis_cluster_cache import RedisClusterCache
from litellm.constants import (
_REALTIME_BODY_CACHE_SIZE,
Expand Down Expand Up @@ -2301,7 +2302,11 @@ async def root_redirect():
user_api_key_cache: UserApiKeyCache = UserApiKeyCache(
default_in_memory_ttl=UserAPIKeyCacheTTLEnum.in_memory_cache_ttl.value
)
spend_counter_cache: Final = DualCache(default_in_memory_ttl=UserAPIKeyCacheTTLEnum.in_memory_cache_ttl.value)
SPEND_COUNTER_CACHE_MAX_SIZE: Final = 10_000
spend_counter_cache: Final = DualCache(
in_memory_cache=InMemoryCache(max_size_in_memory=SPEND_COUNTER_CACHE_MAX_SIZE),
default_in_memory_ttl=UserAPIKeyCacheTTLEnum.in_memory_cache_ttl.value,
)
cli_sso_session_cache: Final = DualCache(default_in_memory_ttl=CLI_SSO_SESSION_TTL_SECONDS)
model_max_budget_limiter: Final = _PROXY_VirtualKeyModelMaxBudgetLimiter(dual_cache=spend_counter_cache)
litellm.logging_callback_manager.add_litellm_callback(model_max_budget_limiter)
Expand Down
18 changes: 18 additions & 0 deletions tests/test_litellm/proxy/test_proxy_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7542,6 +7542,24 @@ async def test_store_model_in_db_db_failure_graceful(monkeypatch):
# =====================================================================


def test_spend_counter_cache_keeps_active_counters_warm(monkeypatch):
from litellm.caching.in_memory_cache import InMemoryCache
from litellm.proxy.proxy_server import spend_counter_cache

cache = InMemoryCache(
max_size_in_memory=spend_counter_cache.in_memory_cache.max_size_in_memory,
default_ttl=60,
)
monkeypatch.setattr(spend_counter_cache, "in_memory_cache", cache)

sentinel = "spend:key:sentinel"
cache.set_cache(key=sentinel, value=1.0)
for index in range(300):
cache.set_cache(key=f"spend:end_user:scope-{index}", value=1.0)

assert cache.get_cache(key=sentinel) == 1.0


@pytest.mark.asyncio
async def test_get_current_spend_reads_redis_first():
"""get_current_spend should prefer Redis over in-memory."""
Expand Down
Loading