Conversation
Greptile SummaryAdds OpenRouter pricing, token limits, and capability metadata for
Confidence Score: 4/5The metadata looks consistent, but the repository’s required functional coverage should be added before merge The pricing and limits follow existing registry conventions, but this new spend-calculation behavior has no test proving the model resolves and calculates costs correctly Files Needing Attention: model_prices_and_context_window.json, litellm/model_prices_and_context_window_backup.json
|
| Filename | Overview |
|---|---|
| model_prices_and_context_window.json | Adds consistent OpenRouter model metadata but lacks required functional pricing coverage |
| litellm/model_prices_and_context_window_backup.json | Mirrors the new model metadata from the primary registry |
Reviews (1): Last reviewed commit: "Add OpenRouter pricing for z-ai/glm-5.3-..." | Re-trigger Greptile
| "supports_reasoning": true, | ||
| "supports_tool_choice": true | ||
| }, | ||
| "openrouter/z-ai/glm-5.3-flash": { |
There was a problem hiding this comment.
Missing functional pricing test
This adds pricing behavior without a functional cost-calculation test. Repository guidance requires meaningful tests for new features, so this requirement must be satisfied before merging
Context Used: CLAUDE.md (source)
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
Superseded by the rolling registry PR #31884. The openrouter/z-ai/glm-5.3-flash entry already exists on litellm_internal_staging with the live OpenRouter API prices (7.5e-8 input, 2.5e-7 output, 1.5e-8 cache read), which differ from the values proposed here. Thanks for flagging the gap. |
TLDR
Problem this solves:
openrouter/z-ai/glm-5.3-flashhas no pricing row, so spend logs $0 or a fallback estimatezai/glm-5.3-flashrow exists, but not the OpenRouter oneHow it solves it:
openrouter/z-ai/glm-5.3-flashtomodel_prices_and_context_window.jsonand the backup copyzai/glm-5.3-flashrow (OpenRouter is running a temporary 50% promo through 2026-09-09; not encoded)https://openrouter.ai/api/v1/modelsUser Flow
Before: a developer routing GLM 5.3 Flash through OpenRouter sees no cost for those calls
"model": "openrouter/z-ai/glm-5.3-flash"After: the same request records real spend
"model": "openrouter/z-ai/glm-5.3-flash"Caveats
zai/glm-5.3-flashrow.Type
🆕 New Feature
Changes
model_prices_and_context_window.json: addopenrouter/z-ai/glm-5.3-flashlitellm/model_prices_and_context_window_backup.json: same row