Skip to content

test(store_model_in_db): assert the 400 contract in the unknown-model spend log test #39842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mateo-berri merged 2 commits into from
Sep 5, 2026
+5 −3
Merged

test(store_model_in_db): assert the 400 contract in the unknown-model spend log test #39842

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f27699a
test(store_model_in_db): assert the 400 contract in the unknown-model…
mateo-berri Sep 5, 2026
a61bead
test(store_model_in_db): accept both 400 shapes in the unknown-model …
mateo-berri Sep 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions tests/store_model_in_db_tests/test_openai_error_handling.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,9 @@ async def test_chat_completion_bad_model_with_spend_logs():
except json.JSONDecodeError:
print(f"Could not parse response body as JSON: {response.text}")

assert (
response.status_code == 400
), f"expected HTTP 400, got {response.status_code}: {response.text}"
assert (
litellm_call_id is not None
), "Failed to get LiteLLM Call ID from response headers"
Expand Down Expand Up @@ -191,7 +194,7 @@ async def test_chat_completion_bad_model_with_spend_logs():
# Verify the structure of the log entry
Comment thread
greptile-apps[bot] marked this conversation as resolved.
assert log_entry["request_id"] == litellm_call_id
assert log_entry["model"] == "non-existent-model"
assert log_entry["model_group"] == "non-existent-model"
assert log_entry["model_group"] in ("", "non-existent-model")
assert log_entry["spend"] == 0.0
assert log_entry["total_tokens"] == 0
assert log_entry["prompt_tokens"] == 0
Expand All @@ -206,8 +209,7 @@ async def test_chat_completion_bad_model_with_spend_logs():
error_info = log_entry["metadata"]["error_information"]
assert "traceback" in error_info
assert error_info["error_code"] == "400"
assert error_info["error_class"] == "BadRequestError"
assert "litellm.BadRequestError" in error_info["error_message"]
assert error_info["error_class"] in ("ProxyModelNotFoundError", "BadRequestError")
assert "non-existent-model" in error_info["error_message"]

# Verify request details
Expand Down
Loading