feat(baseten): add baseten/zai-org/GLM-5.3 to model pricing registry (#39342) - #39656
feat(baseten): add baseten/zai-org/GLM-5.3 to model pricing registry (#39342)#39656dlowzzxx wants to merge 2 commits into
Conversation
Greptile SummaryAdds Baseten GLM-5.3 pricing, context limits, and capability metadata to both model registries.
Confidence Score: 4/5The PR appears safe to merge, with only a non-blocking redundant test comment to remove. The registry copies remain synchronized, and the added tests exercise local metadata and cached-token accounting without an established behavioral failure. Files Needing Attention: tests/test_litellm/llms/baseten/chat/test_baseten_completions.py
|
| Filename | Overview |
|---|---|
| model_prices_and_context_window.json | Adds the GLM-5.3 Baseten registry entry with pricing, token limits, and capability flags; no correctness issue was established. |
| litellm/model_prices_and_context_window_backup.json | Mirrors the new GLM-5.3 entry exactly in the packaged fallback registry. |
| tests/test_litellm/llms/baseten/chat/test_baseten_completions.py | Adds isolated metadata and cost tests; one inline comment unnecessarily restates straightforward arithmetic. |
Reviews (1): Last reviewed commit: "feat(baseten): add baseten/zai-org/GLM-5..." | Re-trigger Greptile
| prompt_tokens_details=PromptTokensDetailsWrapper(cached_tokens=400), | ||
| ) | ||
| prompt_cost, completion_cost = litellm.cost_per_token( | ||
| "baseten/zai-org/GLM-5.3", usage_object=usage |
There was a problem hiding this comment.
This comment repeats the constants and operations expressed directly by the following calculation, adding maintenance noise and creating an opportunity for the explanation to drift when the test inputs change.
Context Used: CLAUDE.md (source)
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
Superseded by the rolling registry PR #39388, which carries the same GLM-5.3 prices and limits with vision enabled per Baseten docs |
Closes #39342
Summary
Adds baseten/zai-org/GLM-5.3 to LiteLLM's model pricing and capability registry across both model_prices_and_context_window.json and litellm/model_prices_and_context_window_backup.json according to upstream Baseten specifications.
Key Changes
Tests
Type of Change