Repository navigation
fix(ui): read the preset catalog at runtime in the dashboard tests #39478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mateo-berri
merged 3 commits into
litellm_internal_staging
from
litellm_ui_presets_mock_build_ctx
Sep 3, 2026
Merged
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: hmm I never really liked this drilling. Maybe it could be absolute...?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed it's not pretty, but I'd keep it: anchor-on-own-file-and-walk-up is the existing pattern on both sides of the repo, and there is no "absolute" alternative here that isn't machine-specific.
scripts/gen-api-types.mjscomputesdashboardDirandrepoRootby walking up fromimport.meta.urlwith..hops;vitest.config.tsanchors its alias withresolve(__dirname, "src").Path(__file__).resolve().parents[2], 18 more usePath(__file__).parents[2] / "model_prices_and_context_window.json", and a handful goparents[3..5]. No shared repo-root helper exists.process.cwd()was the previous version of this line; Greptile flagged it (vitest from the repo root fails at import time), which is why fcc9b81 moved to__dirname.The only dot-free option is a repo-root constant
defined invitest.config.tsplus a global.d.tssonext buildstill type-checks. Happy to add that once a second test needs a repo-root path, but for one consumer it's more machinery than the line it replaces.