Conversation
Contributor
Greptile SummaryThis PR aligns omitted raw pass-through authentication settings with the typed secure default and adds focused regression coverage
Confidence Score: 5/5The PR appears safe to merge No blocking failure remains
|
| Filename | Overview |
|---|---|
| litellm/proxy/auth/user_api_key_auth.py | Centralized checks now treat an omitted raw pass-through auth field as authenticated, matching the request-time default |
| litellm/proxy/pass_through_endpoints/pass_through_endpoints.py | Raw pass-through route registration now defaults omitted authentication to enabled |
| tests/test_litellm/proxy/auth/test_user_api_key_auth.py | Adds focused coverage confirming centralized checks still execute when raw pass-through configuration omits auth |
| tests/test_litellm/proxy/pass_through_endpoints/test_passthrough_auth_default.py | Adds focused registration coverage for the secure omitted-auth default |
Reviews (2): Last reviewed commit: "fix(proxy): enforce auth defaults for ra..." | Re-trigger Greptile
Contributor
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
lzhan011
force-pushed
the
bugfix/pass-through-auth-default
branch
3 times, most recently
from
September 1, 2026 22:17
f7fc5ee to
754c3d5
Compare
Author
|
@greptileai please re-review the auth-default changes after rebasing onto the latest staging branch and retaining the focused regression coverage |
1 task
Author
|
OSV failure is tracked in #39217 and comes from unchanged staging locks; this PR only changes pass-through authentication code and tests |
lzhan011
force-pushed
the
bugfix/pass-through-auth-default
branch
from
September 2, 2026 19:47
754c3d5 to
b69818f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR
Problem this solves:
authdisagrees with the typed secure defaultHow it solves it:
authvalues totrueUser Flow
Before: a proxy admin omits
authand an exhausted key can still reach the pass-through upstream/internal/providerwithout anauthfield and restarts the proxyAfter: the same request is stopped by the policy already attached to the key
/internal/providerwithout anauthfield and restarts the proxyRelevant issues
Fixes #35534
Linear ticket
Pre-Submission checklist
Local checks
litellm_internal_stagingScreenshots / Proof of Fix
A live before/after curl run needs a DB-backed proxy so the same virtual key can be placed over budget. This checkout has no PostgreSQL service or
DATABASE_URLBefore (97dbd8e)
After (754c3d5)
Type
Bug Fix
Caveats (if any)
CI baseline
uv.lockuv.lockby the repository dependency guardFinal Attestation