Skip to content

fix: update Scaleway models list - #38201

Open
Quentinchampenois wants to merge 1 commit into
BerriAI:litellm_internal_stagingfrom
Quentinchampenois:fix/update-scaleway-models
Open

fix: update Scaleway models list#38201
Quentinchampenois wants to merge 1 commit into
BerriAI:litellm_internal_stagingfrom
Quentinchampenois:fix/update-scaleway-models

Conversation

@Quentinchampenois

@Quentinchampenois Quentinchampenois commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

TLDR

Problem this solves:

  • Current model list is not synchronized with available models

Pre-Submission checklist

Please complete all items before asking a LiteLLM maintainer to review your PR

  • I have added meaningful tests
  • The handful of test files covering my change pass locally, e.g. uv run pytest tests/test_litellm/<your_test_file>.py -v. Leave the suites (make test-unit-*, make test-unit) to CI: it finishes in ~15 minutes where a laptop takes an hour or more
  • x ] My PR passes all required CI/CD checks (e.g., lint, schema.d.ts sync check, etc.)
  • My PR's scope is as isolated as possible; it only solves 1 specific problem
  • I have received a Greptile Confidence Score of at least 4/5 before requesting a maintainer review (Greptile reviews automatically once the PR is opened; only comment @greptileai to re-request a review after pushing changes)

Delays in PR merge?

If you're seeing a delay in your PR being merged, ping the LiteLLM Team on Slack (#pr-review).

Screenshots / Proof of Fix

🆕 New Feature
🐛 Bug Fix
🧹 Refactoring
📖 Documentation
🚄 Infrastructure
✅ Test

Caveats (if any)

QA runbook

Final Attestation

  • The tests check the right things, including the edge cases, and regressions in the respective real-world customer use-cases are not possible after this PR

@codecov

codecov Bot commented Aug 25, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@Quentinchampenois

Copy link
Copy Markdown
Contributor Author

@greptile-apps review ?

@Quentinchampenois
Quentinchampenois marked this pull request as ready for review September 2, 2026 08:12
@greptile-apps

greptile-apps Bot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Updates the Scaleway model catalog to add two current models and remove four older entries.

  • Adds GLM 5.2 and DeepSeek V4 Flash metadata.
  • Removes four Scaleway model records.
  • Leaves the packaged fallback model map unsynchronized.

Confidence Score: 4/5

The PR should not merge until the packaged fallback model map is synchronized with the root map.

Local-map users and remote-map fallback paths load an unchanged backup, causing them to miss the additions and retain the removals from this update.

Files Needing Attention: model_prices_and_context_window.json and litellm/model_prices_and_context_window_backup.json

Important Files Changed

Filename Overview
model_prices_and_context_window.json Updates six Scaleway catalog entries, but the corresponding packaged fallback map is not updated.

Reviews (1): Last reviewed commit: "fix: update Scaleway models list" | Re-trigger Greptile

"input_cost_per_token": 1.8e-06,
"litellm_provider": "scaleway",
"max_input_tokens": 256000,
"max_output_tokens": 16384,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Fallback model map remains stale

When LITELLM_LOCAL_MODEL_COST_MAP is enabled or remote map loading falls back to the packaged copy, the unchanged backup omits these two additions and retains the four removed models, causing model lookup, capability detection, and pricing to differ from normal remote-map operation.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @mateo-berri I wonder if there is a change I must do or this is an informational feedback ?
Thanks !

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise this PR is ready for review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant