fix: update Scaleway models list - #38201
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
@greptile-apps review ? |
Greptile SummaryUpdates the Scaleway model catalog to add two current models and remove four older entries.
Confidence Score: 4/5The PR should not merge until the packaged fallback model map is synchronized with the root map. Local-map users and remote-map fallback paths load an unchanged backup, causing them to miss the additions and retain the removals from this update. Files Needing Attention: model_prices_and_context_window.json and litellm/model_prices_and_context_window_backup.json
|
| Filename | Overview |
|---|---|
| model_prices_and_context_window.json | Updates six Scaleway catalog entries, but the corresponding packaged fallback map is not updated. |
Reviews (1): Last reviewed commit: "fix: update Scaleway models list" | Re-trigger Greptile
| "input_cost_per_token": 1.8e-06, | ||
| "litellm_provider": "scaleway", | ||
| "max_input_tokens": 256000, | ||
| "max_output_tokens": 16384, |
There was a problem hiding this comment.
Fallback model map remains stale
When LITELLM_LOCAL_MODEL_COST_MAP is enabled or remote map loading falls back to the packaged copy, the unchanged backup omits these two additions and retains the four removed models, causing model lookup, capability detection, and pricing to differ from normal remote-map operation.
There was a problem hiding this comment.
Hello @mateo-berri I wonder if there is a change I must do or this is an informational feedback ?
Thanks !
There was a problem hiding this comment.
Otherwise this PR is ready for review
TLDR
Problem this solves:
Pre-Submission checklist
Please complete all items before asking a LiteLLM maintainer to review your PR
uv run pytest tests/test_litellm/<your_test_file>.py -v. Leave the suites (make test-unit-*,make test-unit) to CI: it finishes in ~15 minutes where a laptop takes an hour or more@greptileaito re-request a review after pushing changes)Delays in PR merge?
If you're seeing a delay in your PR being merged, ping the LiteLLM Team on Slack (#pr-review).
Screenshots / Proof of Fix
🆕 New Feature
🐛 Bug Fix
🧹 Refactoring
📖 Documentation
🚄 Infrastructure
✅ Test
Caveats (if any)
QA runbook
Final Attestation