Skip to content

fix(ui): replace undefined antd icon names left in skill_detail - #38110

Closed
tin-berri wants to merge 1 commit into
litellm_internal_stagingfrom
litellm_fix_skill_detail_antd_icons
Closed

tin-berri wants to merge 1 commit into
litellm_internal_stagingfrom
litellm_fix_skill_detail_antd_icons

Conversation

@tin-berri

Copy link
Copy Markdown
Contributor

TLDR

Problem this solves:

  • The dashboard type gate is red on staging itself
  • skill_detail.tsx references CheckOutlined and CopyOutlined, which no longer exist

How it solves it:

  • Uses the lucide-react Check and Copy icons the file already imports and uses elsewhere

User Flow

Before: any branch rebased onto litellm_internal_staging fails npm run build on a file it never touched

  1. They run npm run build in ui/litellm-dashboard
  2. It fails with Type error: Cannot find name 'CheckOutlined' at src/components/claude_code_plugins/skill_detail.tsx:346
  3. The file is byte-identical to the base branch, so nothing in their diff can fix it

After: the same build passes

  1. They run npm run build in ui/litellm-dashboard and it completes
  2. The marketplace command copy button shows the same Check and Copy icons as the file's other copy buttons

Relevant issues

The antd icon JSX came back in via #33514, which predates #37553's icon migration; the file's imports were already lucide-react so the names were undefined

Linear ticket

Pre-Submission checklist

  • I have added meaningful tests
  • My PR passes all CI/CD checks (e.g., lint, format, unit tests)
  • My PR's scope is as isolated as possible; it only solves 1 specific problem
  • I have received a Greptile Confidence Score of at least 4/5 before requesting a maintainer review

Screenshots / Proof of Fix

Before (merge base 10b42a8)

$ npm run build
Type error: Cannot find name 'CheckOutlined'.  (skill_detail.tsx:346)

After (PR tip 3e07a65)

$ npm run build
Compiled successfully

UI check: /ui/?page=claude-code-plugins, open a skill detail, click the marketplace command copy button, the icon flips to a check like the file's other copy buttons

@tin-berri

Copy link
Copy Markdown
Contributor Author

@greptileai can you reply here with a score and why that score?

@greptile-apps

greptile-apps Bot commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Score: 5/5

The fix is minimal, correct, and exactly addresses the stated problem:

  • CheckOutlined and CopyOutlined are antd icon names that don't exist in scope — the file's imports are lucide-react (Check, Copy), not antd icons
  • The replacement uses the same Check/Copy components with className="size-3" — consistent with how the other copy buttons in the same file are styled
  • Single-line change, zero blast radius, no logic touched

The build error described in the PR is real and the fix is the right one.

@greptile-apps

greptile-apps Bot commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Replaces undefined Ant Design icon references in the marketplace command copy button with the file’s existing Lucide Check and Copy components.

  • Aligns the button with the component’s other copy controls.
  • Restores successful dashboard type-checking and build behavior.

Confidence Score: 5/5

The PR appears safe to merge with no actionable issues identified.

The replacement components are already imported and used with the same sizing and state behavior by sibling copy buttons in this component.

Important Files Changed

Filename Overview
ui/litellm-dashboard/src/components/claude_code_plugins/skill_detail.tsx The icon replacement uses existing imports and exactly matches the established icon and copied-state pattern of sibling buttons.

Reviews (1): Last reviewed commit: "fix(ui): replace undefined antd icon nam..." | Re-trigger Greptile

@tin-berri

Copy link
Copy Markdown
Contributor Author

The undefined icon names are already fixed on staging, closing as obsolete

@tin-berri tin-berri closed this Aug 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant