fix(ci): raise the 55m unit-shard job timeouts to the 60m the startup gate requires - #38099
fix(ci): raise the 55m unit-shard job timeouts to the 60m the startup gate requires#38099oneKn8 wants to merge 1 commit into
Conversation
Greptile SummaryRaises the job timeout from 55 to 60 minutes for three unit-test shards so their 20-minute test budgets fit behind the shared workflow’s 35-minute setup ceiling and 5-minute runner allowance.
Confidence Score: 5/5The PR appears safe to merge because all three timeout changes satisfy the existing startup-safety invariant without altering test selection or execution behavior. The affected shards each retain a 20-minute pytest budget and now receive the required 60-minute job deadline, matching the reusable workflow contract and established sibling configuration.
|
| Filename | Overview |
|---|---|
| .github/workflows/test-unit.yml | The three timeout increases match the reusable workflow’s documented minimum and introduce no actionable issue. |
Reviews (1): Last reviewed commit: "fix(ci): raise the 55m unit-shard job ti..." | Re-trigger Greptile
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
… gate requires check_workflow_startup_safety fails on every PR since BerriAI#37804: three shards give pytest 20m but cap the job at 55m, inside the 35m setup ceiling plus 5m runner overhead the gate reserves. code-quality has been red on every open PR since.
ab712c6 to
f3711f7
Compare
|
Superseded by #38139, which landed the same 55m to 60m change on staging. Closing. |
TLDR
Problem this solves:
code-qualityfails on every PR opened since perf(ci): give the two longest unit shards the runner's spare cores #37804 landedHow it solves it:
job-timeout-minutes: 55entries to 60check_workflow_startup_safety.pypasses againUser Flow
Before: every contributor's PR shows a failing required-adjacent check they cannot fix
litellm_internal_stagingunitgives pytest 20m but caps the job at 55m ... raise job-timeout-minutes to at least 60", three times.github/workflows/test-unit.yml, a file their PR does not touchAfter: the same PR runs code-quality green
litellm_internal_stagingRelevant issues
Regression from #37804 (the two resized shards, plus
enterprise-package, kept a 55m cap). Every open PR created after it shows the same red, e.g. #38047, #38048, #38049, #38051, #38053.Pre-Submission checklist
tests/code_coverage_tests/check_workflow_startup_safety.py, which this change turns green)uv run python ./tests/code_coverage_tests/check_workflow_startup_safety.pyprints "Workflow startup invariants hold (setup ceiling 35m)"Screenshots / Proof of Fix
CI-only change; the proof is the gate itself.
Before (d1f3778, staging HEAD)
After (this PR)