Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions litellm/llms/bedrock/chat/converse_transformation.py
Original file line number Diff line number Diff line change
Expand Up @@ -591,7 +591,9 @@ def map_tool_choice_values(
message=f"Bedrock doesn't support tool_choice={tool_choice}. To drop it from the call, set `litellm.drop_params = True.",
status_code=400,
)
elif tool_choice == "required":
elif tool_choice in ("required", "any"):
# Bedrock's native value for "call some tool" is literally `any`,
# so accepting "required" while rejecting "any" was incoherent.
Comment on lines +595 to +596

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Remove redundant mapping comments

The comments here and beside the error-message assertion in the new test restate straightforward code rather than explaining complex behavior, adding maintenance noise that can drift from the implementation.

Context Used: CLAUDE.md (source)

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

return ToolChoiceValuesBlock(any={})
elif tool_choice == "auto":
return ToolChoiceValuesBlock(auto={})
Expand All @@ -603,7 +605,7 @@ def map_tool_choice_values(
return ToolChoiceValuesBlock(tool=specific_tool)
else:
raise litellm.utils.UnsupportedParamsError(
message=f"Bedrock doesn't support tool_choice={tool_choice}. Supported tool_choice values=['auto', 'required', json object]. To drop it from the call, set `litellm.drop_params = True.",
message=f"Bedrock doesn't support tool_choice={tool_choice}. Supported tool_choice values=['auto', 'required', 'any', json object]. To drop it from the call, set `litellm.drop_params = True.",
status_code=400,
)

Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,43 @@
"""`tool_choice="any"` is Bedrock's own native value and must be accepted."""

import pytest

import litellm
from litellm.llms.bedrock.chat.converse_transformation import AmazonConverseConfig

MODEL = "anthropic.claude-3-haiku-20240307-v1:0"


class TestBedrockToolChoiceAny:
def setup_method(self):
self.config = AmazonConverseConfig()

@pytest.mark.parametrize("tool_choice", ["required", "any"])
def test_required_and_any_both_map_to_bedrock_any(self, tool_choice):
result = self.config.map_tool_choice_values(model=MODEL, tool_choice=tool_choice, drop_params=False)

assert result == {"any": {}}

def test_auto_is_unchanged(self):
result = self.config.map_tool_choice_values(model=MODEL, tool_choice="auto", drop_params=False)

assert result == {"auto": {}}

def test_specific_tool_is_unchanged(self):
result = self.config.map_tool_choice_values(
model=MODEL,
tool_choice={"type": "function", "function": {"name": "get_weather"}},
drop_params=False,
)

assert result == {"tool": {"name": "get_weather"}}

def test_unknown_value_still_raises_and_lists_any(self):
with pytest.raises(litellm.utils.UnsupportedParamsError) as exc_info:
self.config.map_tool_choice_values(model=MODEL, tool_choice="definitely_not_supported", drop_params=False)

# The error text is the discoverability surface for these values.
assert "'any'" in str(exc_info.value)

def test_none_still_drops_when_drop_params_is_set(self):
assert self.config.map_tool_choice_values(model=MODEL, tool_choice="none", drop_params=True) is None
Loading