fix(ui): keep completion-mode models in the playground chat dropdown - #37954
Merged
yuneng-berri merged 1 commit intoAug 22, 2026
Merged
Conversation
PR #36130 added a KNOWN_MODEL_MODES guard to isModelCompatibleWithEndpoint that hides any model whose mode isn't in the ModelMode enum, to keep rerank/ocr/batch/etc. models out of chat-style endpoints. mode: completion (legacy text-completion models) wasn't in that enum, so it got caught by the same guard and disappeared from every endpoint, including chat, where it routes fine. Add ModelMode.COMPLETION and map it to EndpointType.CHAT like the other chat-compatible modes.
Contributor
Greptile SummaryAdds
Confidence Score: 5/5The PR appears safe to merge, with no concrete blocking or non-blocking issue established in the changed code. The change restores completion-mode models to the existing chat-compatible filtering path and adds focused regression coverage without altering request construction or backend routing.
|
| Filename | Overview |
|---|---|
| ui/litellm-dashboard/src/components/chat_ui/mode_endpoint_mapping.tsx | Recognizes completion-mode models and maps them to the existing chat-compatible endpoint behavior; no actionable defect was established. |
| ui/litellm-dashboard/src/app/(dashboard)/playground/components/chat_ui/EndpointUtils.test.tsx | Adds focused coverage confirming completion-mode filtering for compatible and incompatible endpoint categories. |
Reviews (1): Last reviewed commit: "fix(ui): keep completion-mode models in ..." | Re-trigger Greptile
yucheng-berri
approved these changes
Aug 22, 2026
yuneng-berri
added a commit
that referenced
this pull request
Aug 22, 2026
…37954) PR #36130 added a KNOWN_MODEL_MODES guard to isModelCompatibleWithEndpoint that hides any model whose mode isn't in the ModelMode enum, to keep rerank/ocr/batch/etc. models out of chat-style endpoints. mode: completion (legacy text-completion models) wasn't in that enum, so it got caught by the same guard and disappeared from every endpoint, including chat, where it routes fine. Add ModelMode.COMPLETION and map it to EndpointType.CHAT like the other chat-compatible modes. (cherry picked from commit 1c421f3)
Merged
5 tasks
yuneng-berri
added a commit
that referenced
this pull request
Aug 22, 2026
…(backport to rc/1.98.0) (#37955) * fix(ui): keep completion-mode models in the playground chat dropdown (#37954) PR #36130 added a KNOWN_MODEL_MODES guard to isModelCompatibleWithEndpoint that hides any model whose mode isn't in the ModelMode enum, to keep rerank/ocr/batch/etc. models out of chat-style endpoints. mode: completion (legacy text-completion models) wasn't in that enum, so it got caught by the same guard and disappeared from every endpoint, including chat, where it routes fine. Add ModelMode.COMPLETION and map it to EndpointType.CHAT like the other chat-compatible modes. (cherry picked from commit 1c421f3) * chore: update Next.js build artifacts (2026-08-22 18:42 UTC, node v24.19.0)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
PR #36130 added a
KNOWN_MODEL_MODESguard toisModelCompatibleWithEndpointso models with unrecognized modes (batch, rerank, ocr, etc.) don't show up under chat-style playground endpoints.mode: completion(legacy text-completion models) wasn't in theModelModeenum, so it got caught by the same guard and disappeared from the playground dropdown entirely, including the chat endpoint it actually works with — 36 models on the default price/context list.Fix
Add
ModelMode.COMPLETION = "completion"and map it toEndpointType.CHAT, same as the other chat-compatible modes.Testing
EndpointUtils.test.tsxasserting acompletion-mode model is compatible withCHAT/RESPONSESand not with unrelated endpoints (e.g.SPEECH).vitest runon the playground + chat_ui suites: 282 passed.