Skip to content

chore(codeowners): own the proxy-extras migrations directory - #37876

Merged
yuneng-berri merged 1 commit into
litellm_internal_stagingfrom
litellm_/migrations-code-owner-c09d78
Aug 21, 2026
Merged

chore(codeowners): own the proxy-extras migrations directory#37876
yuneng-berri merged 1 commit into
litellm_internal_stagingfrom
litellm_/migrations-code-owner-c09d78

Conversation

@yuneng-berri

Copy link
Copy Markdown
Collaborator

TLDR

Problem this solves:

  • Prisma migrations merge with no owning reviewer
  • Two existing CODEOWNERS rules name an unknown owner
  • Those rules are inert, so nobody gets requested

How it solves it:

  • Adds the proxy-extras migrations directory to CODEOWNERS
  • Repoints the two broken entries at a write-access account

User Flow

Before: a contributor changing a schema migration gets it reviewed by whoever happens to look

  1. They open a PR touching litellm-proxy-extras/litellm_proxy_extras/migrations/
  2. The PR's Reviewers box stays empty, with no owner attached to the path
  3. Separately, a PR touching /ui/ also gets no automatic reviewer, because the rule covering it names an account without write access

After: the same PR pulls in the owning reviewers automatically

  1. They open a PR touching litellm-proxy-extras/litellm_proxy_extras/migrations/
  2. The PR's Reviewers box now lists the migrations owners, added by GitHub as code owners
  3. A PR touching /ui/ now does the same, since that rule resolves to a real write-access account

Relevant issues

Linear ticket

Pre-Submission checklist

  • I have added meaningful tests
  • The handful of test files covering my change pass locally, e.g. uv run pytest tests/test_litellm/<your_test_file>.py -v
  • My PR passes all required CI/CD checks (e.g., lint, schema.d.ts sync check, etc.)
  • My PR's scope is as isolated as possible; it only solves 1 specific problem
  • I have received a Greptile Confidence Score of at least 4/5 before requesting a maintainer review

Note on the first two boxes: this PR changes only .github/CODEOWNERS, which has no importable code and no mapped test file, so there is nothing to unit test. GitHub's own CODEOWNERS validator is the authority on whether the file is correct, and its before/after output is below in place of tests.

Screenshots / Proof of Fix

GitHub validates CODEOWNERS server-side and reports every rule it cannot resolve. A rule listing an owner without write access is silently dropped, so the validator is exactly what decides whether these entries do anything.

Shared setup:

gh api "repos/BerriAI/litellm/codeowners/errors?ref=<ref>"

Before (0a5fa4f)

  1. Ask GitHub to validate the file on the merge base
gh api "repos/BerriAI/litellm/codeowners/errors?ref=litellm_internal_staging" \
  --jq '.errors[] | "line \(.line): \(.kind) -> \(.source)"'
  1. Two rules come back rejected, so neither is in force, and no rule covers the migrations directory at all
line 1: Unknown owner -> /ui/ @yuneng-jiang @ryan-crabbe-berri

line 2: Unknown owner -> /litellm/proxy/_experimental/out/ @yuneng-jiang @ryan-crabbe-berri
  1. Read the full message on one of them to see why it was dropped
gh api "repos/BerriAI/litellm/codeowners/errors?ref=litellm_internal_staging" \
  --jq '.errors[0].suggestion'
make sure @yuneng-jiang exists and has write access to the repository
  1. Confirm the cause directly: the named account resolves, but only at read
gh api repos/BerriAI/litellm/collaborators/yuneng-jiang/permission --jq .permission
read

After (6f73e5f)

  1. Ask GitHub to validate the file on this PR's branch
gh api "repos/BerriAI/litellm/codeowners/errors?ref=litellm_%2Fmigrations-code-owner-c09d78" --jq '.errors'
  1. The error list is empty, so every rule in the file now resolves and takes effect
[]
  1. Confirm both owners on the new migrations rule hold write access
for u in yuneng-berri ryan-crabbe-berri; do
  echo "$u: $(gh api repos/BerriAI/litellm/collaborators/$u/permission --jq .permission)"
done
yuneng-berri: write
ryan-crabbe-berri: write
  1. Confirm the new rule is the one matching the migrations path
git show HEAD:.github/CODEOWNERS | grep migrations
/litellm-proxy-extras/litellm_proxy_extras/migrations/ @yuneng-berri @ryan-crabbe-berri

Type

🚄 Infrastructure

Caveats (if any)

  • @yuneng-jiang is a read-only account, not a separate person
  • Ownership applies to PRs opened after this merges

Final Attestation

  • The tests check the right things, including the edge cases, and regressions in the respective real-world customer use-cases are not possible after this PR

Adds ownership of litellm-proxy-extras/litellm_proxy_extras/migrations so
schema migration changes get a review request.

Also repoints the two existing entries at @yuneng-berri. GitHub's CODEOWNERS
validator was rejecting @yuneng-jiang as an unknown owner, which left the
/ui/ and _experimental/out/ rules inert.
@yuneng-berri
yuneng-berri requested a review from a team August 21, 2026 18:48
@greptile-apps

greptile-apps Bot commented Aug 21, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

The PR repairs two inert CODEOWNERS entries and adds ownership for proxy-extras migrations.

  • Replaces the read-only @yuneng-jiang account with @yuneng-berri for UI and experimental output paths.
  • Assigns @yuneng-berri and @ryan-crabbe-berri to the proxy-extras migrations directory.
  • The new path matches the existing migrations directory and is not overridden by a later rule.

Confidence Score: 5/5

The PR appears safe to merge because the CODEOWNERS paths and replacement accounts are supported by the provided validation evidence.

The migrations pattern exactly matches the repository directory, no later rule overrides it, and GitHub’s validator reports that the updated CODEOWNERS file resolves without errors.

Important Files Changed

Filename Overview
.github/CODEOWNERS Updates two invalid owner references and adds a correctly matched migrations ownership rule; no actionable issues found.

Reviews (1): Last reviewed commit: "chore(codeowners): own the proxy-extras ..." | Re-trigger Greptile

@yuneng-berri
yuneng-berri enabled auto-merge August 21, 2026 18:50
@yuneng-berri
yuneng-berri merged commit 247eaaa into litellm_internal_staging Aug 21, 2026
66 checks passed
@yuneng-berri
yuneng-berri deleted the litellm_/migrations-code-owner-c09d78 branch August 21, 2026 18:58
@codecov

codecov Bot commented Aug 21, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants