test: remove the five test functions a later definition shadows

[yuneng-berri]

TLDR

Problem this solves:

• Five test functions are shadowed by a later definition
• Python never binds them, so pytest never collects them
• August's sweep took the count 22 to 13; later work reached 5
• conftest copy.py is a duplicate pytest never loads

How it solves it:

• Deletes the five unreachable definitions and the stray conftest
• Keeps the surviving twin in every case, which is the better one
• Collected count is 416 before and after

User Flow

Before: someone reads a test, believes it runs, and it does not

1. A maintainer opens tests/logging_callback_tests/test_sqs_logger.py looking for what covers the SQS success path
2. They find test_async_log_success_event_adds_to_queue at line 154 and read its assertions
3. That definition is dead: an identical name at line 278 rebinds it, so the one they read has never executed
4. Any conclusion they draw about what is covered, or any edit they make to line 154, has no effect on CI

After: the file contains only definitions that run

1. The maintainer opens the same file and finds one test_async_log_success_event_adds_to_queue
2. It is the surviving version, which additionally stubs asyncio.create_task
3. Editing it changes what CI does
4. pytest --collect-only reports the same 416 tests it did before, because the deleted definitions were never among them

Relevant issues

Linear ticket

Pre-Submission checklist

• I have added meaningful tests
• The handful of test files covering my change pass locally, e.g. uv run pytest tests/test_litellm/<your_test_file>.py -v
• My PR passes all required CI/CD checks (e.g., lint, schema.d.ts sync check, etc.)
• My PR's scope is as isolated as possible; it only solves 1 specific problem
• I have received a Greptile Confidence Score of at least 4/5 before requesting a maintainer review

Screenshots / Proof of Fix

The claim is that these definitions never ran, so the proof is that removing them changes nothing pytest collects. The detector below walks every scope in the test tree and reports each name a later definition rebinds.

Shared setup, the four files touched:

FILES=(tests/llm_translation/test_bedrock_completion.py tests/llm_translation/test_openai.py
       tests/local_testing/test_completion_cost.py tests/logging_callback_tests/test_sqs_logger.py)

Before (5290150)

The shadowed definitions exist and are unreachable

1. Command, scripts/find_shadowed.py being the AST detector described above:

python scripts/find_shadowed.py

2. Output:

tests/llm_translation/test_bedrock_completion.py  scope=module  test_bedrock_cross_region_inference  dead at line(s) 1205
tests/llm_translation/test_openai.py  scope=TestOpenAIChatCompletion  test_prompt_caching  dead at line(s) 288
tests/local_testing/test_completion_cost.py  scope=module  test_cost_calculator_with_base_model_with_router  dead at line(s) 2766
tests/logging_callback_tests/test_sqs_logger.py  scope=module  test_async_log_success_event_adds_to_queue  dead at line(s) 154
tests/logging_callback_tests/test_sqs_logger.py  scope=module  test_async_log_failure_event_adds_to_queue  dead at line(s) 166

shadowed test functions: 5

3. Command:

uv run pytest "${FILES[@]}" --collect-only -q | tail -1

4. Output:

416 tests collected in 0.20s

After (c3545ee)

Nothing is shadowed any more

1. Command, the same detector:

python scripts/find_shadowed.py

2. Output:

shadowed test functions: 0

The collected set is unchanged

1. Command:

uv run pytest "${FILES[@]}" --collect-only -q | tail -1

2. Output:

416 tests collected in 0.27s

Same number, so no test was removed from the run. That is the whole safety argument.

The one keyless file still passes

1. Command:

uv run pytest tests/logging_callback_tests/test_sqs_logger.py -q

2. Output:

18 passed, 1 warning in 4.08s

Every test file still has a runner

1. Command:

python .github/scripts/assert_ci_coverage.py

2. Output:

OK: 2422 test files and 10 Dockerfiles are each invoked by at least one job or carry an explicit allowlist entry.

Type

🧹 Refactoring
✅ Test

Caveats

• Five reappeared after a sweep, so a rule beats another sweep
• That rule belongs in the checker feat(ci): ratchet the test suite's zero-assert, mock-echo and global-state debt #37588 adds, as a follow-up
• Independent of feat(ci): ratchet the test suite's zero-assert, mock-echo and global-state debt #37588; this one only deletes dead definitions
• The three non-SQS files need provider keys, so CI covers them
• The detector is a throwaway, not added to the repo here

Final Attestation

• The tests check the right things, including the edge cases, and regressions in the respective real-world customer use-cases are not possible after this PR

[greptile-apps]

Greptile Summary

This PR removes five Python test definitions that were unreachable because later definitions rebound the same names, plus an unused nonstandard conftest copy.

• Preserves the test functions pytest actually collects.
• Removes misleading dead test bodies from Bedrock, OpenAI, cost-calculation, and SQS test modules.
• Deletes tests/proxy_unit_tests/conftest copy.py, which pytest does not automatically load.

Confidence Score: 5/5

The PR appears safe to merge because it removes only definitions and configuration-copy code that were not active in pytest collection.

Each removed test was rebound by a later same-named definition in the same Python scope, while the deleted nonstandard conftest filename was neither automatically discovered nor explicitly loaded.

Important Files Changed

Filename	Overview
tests/llm_translation/test_bedrock_completion.py	Removes an earlier module-level test definition already shadowed by a later definition, without changing collected coverage.
tests/llm_translation/test_openai.py	Removes the first of two same-named class methods; both were no-op test stubs and only the later binding was collectable.
tests/local_testing/test_completion_cost.py	Removes an uncollectable same-named test whose body only imported Router; the surviving parametrized test retains the actual behavior checks.
tests/logging_callback_tests/test_sqs_logger.py	Removes two shadowed queue tests while retaining later versions with equivalent assertions and safer task stubbing.
tests/proxy_unit_tests/conftest copy.py	Deletes a stray nonstandard conftest copy that pytest did not automatically discover and that repository tooling does not explicitly load.

_{Reviews (1): Last reviewed commit: "test: remove the five test functions a l..." | Re-trigger Greptile}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

[tin-berri]

done — #37591 approved. Deletes 5 test function definitions that a later same-named definition in the same scope shadows — Python's own name binding means the earlier definition never gets bound, so pytest never collects it, giving a false sense of coverage to anyone reading the dead one (plus a stray duplicate conftest copy.py). Proof-of-fix is exactly right for this claim: an AST-based detector (scripts/find_shadowed.py) names the precise dead definitions and their line numbers before the change, and pytest --collect-only reports the identical 416-test count before and after removal, confirming nothing that actually ran got deleted. Small, mechanical, part of the same CI-hygiene pass as #37586/#37588/#37590/#37605. CI green.