fix(ci): stop Agent Shin reconsider from triggering on bot comments - #37529
Conversation
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
|
Greptile SummaryThe PR prevents bot-authored comments from starting the Agent Shin reconsider job while preserving reconsider requests from human commenters.
Confidence Score: 5/5The PR appears safe to merge with no actionable defects identified. The new condition applies only to bot-authored issue comments, uses fields available on the configured issue-comment event, and leaves the existing human reconsider and authorization flow unchanged.
|
| Filename | Overview |
|---|---|
| .github/workflows/triage_reconsider.yml | Adds valid job-level bot identity filters to suppress self-triggered reconsider runs without changing human authorization behavior. |
Reviews (1): Last reviewed commit: "fix(ci): stop Agent Shin reconsider from..." | Re-trigger Greptile
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
TLDR
Problem this solves:
How it solves it:
User Flow
Before: a maintainer watching the Agent Shin triage sweep gets a burst of pointless workflow runs, one per PR the sweep touched
@agent-shin reconsiderto bring the PR backdevin-ai-integration[bot]is not authorizedAfter: the same sweep leaves the reconsider run list clean, so the only runs there are real contributor requests
@agent-shin reconsiderinstructions@agent-shin reconsiderstill gets the 👀 reaction and a verdict, exactly as beforeRelevant issues
Linear ticket
Pre-Submission checklist
No tests: the change is a GitHub Actions
if:expression, which has no test harness in this repo. The trigger data below is from the real eventsDelays in PR merge?
If you're seeing a delay in your PR being merged, ping the LiteLLM Team on Slack (#pr-review).
Screenshots / Proof of Fix
issue_commentworkflows always run from the default branch, so the new gate cannot execute from a PR branch. Before is the live behavior onlitellm_internal_staging, After is the same real event payload evaluated against the new conditionBefore (f4b46c8)
Eight runs in 17 seconds, all of them from the sweep's own comments rather than from any contributor
Every later step (reaction, checkout, Python setup, the LLM judge) was skipped, so the run could never have produced a verdict
After (fe97a9d)
github.event.comment.user.type != 'Bot'is false and!endsWith(github.event.comment.user.login, '[bot]')is false, so the job condition is false and no run is created for any of those eight commentsThe added clauses only look at the commenter's account type, so the existing author / OWNER / MEMBER / COLLABORATOR authorization step is what still decides human comments
Type
🚄 Infrastructure
Caveats (if any)
Link to Devin session: https://app.devin.ai/sessions/2e6fbd7ba56d4655b42601c88868a654